From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#21465: [PATCH] CC-modes hierarchy Date: Sun, 13 Sep 2015 16:24:33 -0400 Message-ID: References: <87pp1neg2k.fsf@udel.edu> <20150913160626.GA1086@holos> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442175924 9374 80.91.229.3 (13 Sep 2015 20:25:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Sep 2015 20:25:24 +0000 (UTC) Cc: 21465@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 13 22:25:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZbDpn-0008E8-Q7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Sep 2015 22:25:12 +0200 Original-Received: from localhost ([::1]:37032 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbDpn-00074x-8R for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Sep 2015 16:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbDpj-000727-BS for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2015 16:25:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbDpi-000805-GS for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2015 16:25:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbDpd-0007p0-WA; Sun, 13 Sep 2015 16:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZbDpd-0006t2-OL; Sun, 13 Sep 2015 16:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sun, 13 Sep 2015 20:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21465 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 21465-submit@debbugs.gnu.org id=B21465.144217587826438 (code B ref 21465); Sun, 13 Sep 2015 20:25:01 +0000 Original-Received: (at 21465) by debbugs.gnu.org; 13 Sep 2015 20:24:38 +0000 Original-Received: from localhost ([127.0.0.1]:59312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbDpF-0006sM-Oz for submit@debbugs.gnu.org; Sun, 13 Sep 2015 16:24:38 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:21855) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbDpC-0006sD-Kp for 21465@debbugs.gnu.org; Sun, 13 Sep 2015 16:24:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A3FgA731xV/0jo92hcDoMChAKFVcMLBAICgTw8EQEBAQEBAQGBCkEFg10BAQMBViMFCwsOJhIUGA0kiDcIzyMBAQEBBgEBAQEeizqFBQeELQEEnxeSFINZI2GCWVoigngBAQE X-IPAS-Result: A0A3FgA731xV/0jo92hcDoMChAKFVcMLBAICgTw8EQEBAQEBAQGBCkEFg10BAQMBViMFCwsOJhIUGA0kiDcIzyMBAQEBBgEBAQEeizqFBQeELQEEnxeSFINZI2GCWVoigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="164730948" Original-Received: from 104-247-232-72.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.247.232.72]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 13 Sep 2015 16:24:33 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 76173AE27B; Sun, 13 Sep 2015 16:24:33 -0400 (EDT) In-Reply-To: <20150913160626.GA1086@holos> (Mark Oteiza's message of "Sun, 13 Sep 2015 12:06:26 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106494 Archived-At: > Nope, for some reason, doing (c-make-inherited-keymap) in the map > definition in 24, I end up only with a Foo++ menu. Simply using > (make-keymap), I'd end with with both Foo++ and C++ menus. Oh, you mean that your code uses c-make-inherited-keymap and the change breaks your code, so you then try to fix it by replacing it with make-sparse-keymap or make-keymap. Indeed, that's not the right fix. The right fix is to complain about the removal of c-make-inherited-keymap because it is used by external CC-mode modes. BTW, you don't need c-make-inherited-keymap. Instead you need (defvar foo++-mode-map (let ((map (make-sparse-keymap))) (set-keymap-parent map c-mode-base-map) ... map)) This should be just as backward compatible as using c-make-inherited-keymap (and "backward" includes XEmacs, here). >> > when there shouldn't be, or: >> > (define-derived-mode foo++-mode c-derivative-mode "Foo++" >> > ...) >> > and fontification is broken. >> >> How is it broken? > Oh, it was broken because I was using (make-syntax-table) instead of > (funcall (c-lang-const c-make-mode-syntax-table c)). It looks like > c-derivative-mode comes with no syntax table, which is alright. Indeed, we could set C's syntax table in c-derivative-mode. That would make a lot of sense, thanks. The proposed patch just introduces c-derivative-mode as a way to make the hierarchy more visible, but it doesn't make c-derivative-mode usable on its own. You could argue that c-derivative-mode should be the same as c-mode, but my patch does not try to do that (yet?). Stefan