From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: Chong Yidong <cyd@gnu.org>, 23632@debbugs.gnu.org
Subject: bug#23632: 25.1.50; Gratuitous undo boundary in latex-insert-block
Date: Fri, 03 Jun 2016 23:05:24 -0400 [thread overview]
Message-ID: <jwv1t4d1wve.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87porxrk4v.fsf@russet.org.uk> (Phillip Lord's message of "Fri, 03 Jun 2016 23:18:56 +0100")
>>> Simple let binding would not give quite the same functionality, because
>>> of the last part -- I also add a boundary to buffers with a greater
>>> recursive depth; with a let binding, I think these would be unbound for
>>> commands that lower the recursion depth.
>> Ah, you mean that the value of undo-auto--undoably-changed-buffers needs
>> to be propagated "out" when we leave the let-binding.
> I *think* so -- I'm not entirely sure. It might make no difference.
It makes a difference, since otherwise we may forget that some changes
were made in a buffer and fail to push a boundary for them. Not super
terribly serious, admittedly.
> I use this variable in several different places in two different places
> though
Not sure what you mean by "use", and there's clearly some typo about
"places" which makes the meaning even more murky.
> -- once when we capture the undoable changes (which happens
> often) and once on at the end of each command.
Right. I see no need for any changes there.
> I'd have to do this let binding in the command loop?
We'd need this right when we enter a recursive-edit (minibuffer or not),
so maybe doing it when we enter the command loop would work.
> My current solution seems simpler, even if it does feel like I have
> created "recursion-level" local variables.
My impression that a let-binding plus a call to
undo-auto--ensure-boundary will be simpler than your patch. But it's
hard to be sure until it's actually implemented.
Stefan
next prev parent reply other threads:[~2016-06-04 3:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 15:11 bug#23632: 25.1.50; Gratuitous undo boundary in latex-insert-block Chong Yidong
2016-05-28 8:22 ` Chong Yidong
2016-05-29 21:51 ` Phillip Lord
2016-05-31 21:42 ` Phillip Lord
2016-06-01 13:15 ` Stefan Monnier
2016-06-02 20:08 ` Phillip Lord
2016-06-03 13:00 ` Stefan Monnier
2016-06-03 16:13 ` Phillip Lord
2016-06-03 17:00 ` Stefan Monnier
2016-06-03 22:18 ` Phillip Lord
2016-06-04 3:05 ` Stefan Monnier [this message]
2016-06-04 8:51 ` Phillip Lord
2016-06-04 16:49 ` Stefan Monnier
2016-06-04 17:17 ` Phillip Lord
2016-06-04 18:41 ` Stefan Monnier
2016-06-06 14:33 ` Phillip Lord
2016-06-06 15:02 ` Stefan Monnier
2016-06-06 15:36 ` Phillip Lord
2016-06-06 15:26 ` Eli Zaretskii
2016-06-06 15:38 ` Phillip Lord
2016-06-06 16:22 ` Eli Zaretskii
2016-06-07 11:20 ` Phillip Lord
2016-06-07 15:09 ` Eli Zaretskii
2016-06-03 2:58 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1t4d1wve.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=23632@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).