From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 29118@debbugs.gnu.org, Allen Li <vianchielfaura@gmail.com>,
Barry OReilly <gundaetiapo@gmail.com>
Subject: bug#29118: 25.2.50; Undoing shell flush output results in weird state
Date: Mon, 13 Nov 2017 08:26:02 -0500 [thread overview]
Message-ID: <jwv1sl2qpj1.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <8760af2vup.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sun, 12 Nov 2017 13:30:22 -0500")
> --- i/lisp/simple.el
> +++ w/lisp/simple.el
> @@ -2579,7 +2579,7 @@ primitive-undo
> (let* ((marker-adj (pop list))
> (m (car marker-adj)))
> (and (eq (marker-buffer m) (current-buffer))
> - (= pos m)
> + (= (abs pos) m)
> (push marker-adj valid-marker-adjustments))))
> ;; Insert string and adjust point
> (if (< pos 0)
Looks correct to me, this belongs in emacs-26, thanks.
Stefan
next prev parent reply other threads:[~2017-11-13 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 21:25 bug#29118: 25.2.50; Undoing shell flush output results in weird state Allen Li
2017-11-10 1:26 ` Noam Postavsky
2017-11-10 8:10 ` Eli Zaretskii
2017-11-12 2:12 ` Noam Postavsky
2017-11-12 4:47 ` Eli Zaretskii
2017-11-26 19:59 ` bug#29461: Wishlist: better facilities for debugging undo problems Noam Postavsky
2017-11-11 7:20 ` bug#29118: 25.2.50; Undoing shell flush output results in weird state Allen Li
2017-11-12 18:30 ` Noam Postavsky
2017-11-13 8:29 ` Allen Li
2017-11-13 13:26 ` Stefan Monnier [this message]
2017-11-15 13:05 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1sl2qpj1.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=29118@debbugs.gnu.org \
--cc=gundaetiapo@gmail.com \
--cc=npostavs@users.sourceforge.net \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).