unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Yuri Khan <yurivkhan@gmail.com>
Cc: 33749@debbugs.gnu.org
Subject: bug#33749: 26.1; input-decode-map to empty vector should preserve echo area
Date: Wed, 19 Dec 2018 13:05:42 -0500	[thread overview]
Message-ID: <jwv1s6dtn33.fsf-monnier+bug#33749@gnu.org> (raw)
In-Reply-To: <CAP_d_8XMu1aCTV8RGO-6exMbYsie2VNP-P_x3Y4t91DbJSM1Bw@mail.gmail.com> (Yuri Khan's message of "Sat, 15 Dec 2018 03:48:00 +0700")

> The call sequence that causes the echo to be cleared looks like this:
>
> command_loop_1 (in keyboard.c)
>   read_key_sequence
>     read_char
>       redisplay
>
> and much of the read_char and read_key_sequence mechanics maintain
> echoing of the current prefix sequence.

Have you been able to track down the precise call to (one of the C entry
point of) `message` which causes the echo area to be cleared in
your case?

> * src/keyboard.c (read_key_sequence): If the current sequence is
>   mapped via `input-decode-map' to an empty sequence and
>   `input-decode-preserve-echo' is non-nil, return -1.

input-decode-map doesn't only apply to the beginning of a key-sequence,
but also in the middle (e.g. in your case, when you do `C-x h` the
input-decode-map likely applies to the "release control modifier" event
that occurs between `C-x` and `h`).

Returning -1 after `C-x` and before we got to read `h` wouldn't
be right.

Also, who/where do you intend to set input-decode-preserve-echo?


        Stefan





  parent reply	other threads:[~2018-12-19 18:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 20:48 bug#33749: 26.1; input-decode-map to empty vector should preserve echo area Yuri Khan
2018-12-15  6:57 ` Eli Zaretskii
2018-12-15  8:07   ` Yuri Khan
2018-12-15  9:09     ` Eli Zaretskii
2018-12-16  8:29     ` bug#33749: [PATCH] Preserve echo area contents when decoding an empty key sequence (Bug#33749) Yuri Khan
2018-12-19 18:05 ` Stefan Monnier [this message]
2018-12-20 17:33   ` bug#33749: 26.1; input-decode-map to empty vector should preserve echo area Yuri Khan
2018-12-20 18:56     ` Stefan Monnier
2018-12-21 18:36       ` Yuri Khan
2018-12-25 19:35         ` Stefan Monnier
2018-12-25 19:44           ` Eli Zaretskii
2018-12-25 20:07             ` Stefan Monnier
2018-12-26  3:32               ` Eli Zaretskii
2019-01-01 16:09               ` Yuri Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jwv1s6dtn33.fsf-monnier+bug#33749@gnu.org' \
    --to=monnier@iro.umontreal.ca \
    --cc=33749@debbugs.gnu.org \
    --cc=yurivkhan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).