unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
	Lars Ingebrigtsen <larsi@gnus.org>, Juri Linkov <juri@linkov.net>,
	17871@debbugs.gnu.org
Subject: bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function?
Date: Wed, 21 Aug 2019 03:01:23 -0400	[thread overview]
Message-ID: <jwv1rxfvwbi.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87o90jjw3t.fsf@gmail.com> ("Štěpán Němec"'s message of "Wed, 21 Aug 2019 00:44:06 +0200")

>   (defvar __testvar nil)
>   
>   (defun __test-command ()
>     (interactive (ignore (message "__test-command (interactive): %s" __testvar)))
>     (message "__test-command (body): %s" __testvar))
>   
>   (defun __test-advice (orig &rest args)
>     (let ((__testvar t))
>       (apply orig args)))
>   
>   (advice-add '__test-command :around #'__test-advice)
>
> Even with the advice, calling __test-command gives:
>
>   __test-command (interactive): nil
>   __test-command (body): t
>
> I'd expect the advice to have effect on the whole function, including
> the interactive form.

The interactive form is executed to build the args with which the
function will be called (hence your advice is only executed after the
interactive spec), so in order for your code to do what you want,
we'd have to always wrap the interactive spec identically to the body.

Maybe in this case it'd do what you want, but in many other cases
it wouldn't.


        Stefan






  reply	other threads:[~2019-08-21  7:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-29 14:13 bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function? Drew Adams
2014-06-29 15:01 ` Michael Heerdegen
2014-06-29 15:52   ` Drew Adams
2014-06-29 22:03     ` Stefan Monnier
2014-06-29 23:49       ` Drew Adams
2014-06-30 20:48     ` Michael Heerdegen
2019-08-04 12:06       ` Lars Ingebrigtsen
2019-08-04 12:45         ` Michael Heerdegen
2019-08-04 12:56           ` Lars Ingebrigtsen
2019-08-04 15:15             ` Štěpán Němec
2019-08-05  6:26             ` Michael Heerdegen
2019-08-05  8:44               ` Štěpán Němec
2019-08-05  9:21               ` Lars Ingebrigtsen
2019-08-18 12:26                 ` Michael Heerdegen
2019-08-18 13:32                   ` Štěpán Němec
2019-08-18 23:06                     ` Lars Ingebrigtsen
2019-08-18 23:50                       ` Štěpán Němec
2019-08-19  0:35                         ` Drew Adams
2019-08-20 21:49                         ` Juri Linkov
2019-08-20 22:44                           ` Štěpán Němec
2019-08-21  7:01                             ` Stefan Monnier [this message]
2019-08-21  8:17                               ` Štěpán Němec
2019-08-25 15:51                                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1rxfvwbi.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=17871@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=michael_heerdegen@web.de \
    --cc=stepnem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).