unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: 41810@debbugs.gnu.org, Stephen Berman <stephen.berman@gmx.net>
Subject: bug#41810: 28.0.50; [ELPA] adaptive-wrap: Fontify wrap-prefix
Date: Thu, 11 Jun 2020 18:42:26 -0400	[thread overview]
Message-ID: <jwv1rml8cev.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k10d7f2v.fsf@gmail.com> ("Kévin Le Gouguec"'s message of "Thu, 11 Jun 2020 18:16:40 +0200")

> The comment's continuation line starts with ";;;;".  I see two problems
> with this:
>
> 1. The padding characters are not propertized, so we get two fontified
>    semicolons, then two unfontified semicolons.

That looks ugly, indeed.  IIRC the reason is that when we extract the
prefix from the buffer, font-lock hasn't applied its `face` text
property yet.

> 2. Visually, this looks sort of cluttered.  I have searched Debbugs and
>    emacs-devel for a rationale for using (substring fcp -1) instead of
>    unconditionally using spaces, but I could not find any.

I think it just seemed like a good idea.  I suspect it's a matter of taste.
Not sure if it's important enough to justify offering both behaviors.

> See second screenshot, taken from emacs -Q -rv, with:

That's ugly, indeed.  Not sure whether the problem really comes from nor
where it should be fixed, but it's clearly a bug.


        Stefan






  reply	other threads:[~2020-06-11 22:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 16:16 bug#41810: 28.0.50; [ELPA] adaptive-wrap: Fontify wrap-prefix Kévin Le Gouguec
2020-06-11 22:42 ` Stefan Monnier [this message]
2020-06-12  8:50   ` Kévin Le Gouguec
2020-06-12 15:33     ` Stefan Monnier
2020-06-12 22:48       ` Kévin Le Gouguec
2020-06-21 15:34         ` bug#41810: [PATCH][ELPA] " Kévin Le Gouguec
2020-06-21 18:32           ` Basil L. Contovounesios
2020-06-21 22:01             ` Kévin Le Gouguec
2020-08-14 17:15               ` Lars Ingebrigtsen
2020-08-14 17:58                 ` Kévin Le Gouguec
2020-08-14 17:59                   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1rml8cev.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=41810@debbugs.gnu.org \
    --cc=kevin.legouguec@gmail.com \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).