From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Wanrong Lin <wrglin@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Andreas Schwab <schwab@linux-m68k.org>,
39484@debbugs.gnu.org
Subject: bug#39484: 26.3; try-completion bug
Date: Wed, 28 Oct 2020 12:34:00 -0400 [thread overview]
Message-ID: <jwv1rhigwzh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <962e72d1-451f-7725-a22c-e35b4a5784b1@gmail.com> (Wanrong Lin's message of "Wed, 28 Oct 2020 11:47:34 -0400")
> The examples I gave are real life situations.
All the examples I see are of the "abcd" or "xyz", i.e. made up examples.
I understand they are meant to illustrate real-life examples, but they
are not themselves real life.
> 1. x is a prefix of y, ignoring case.
> 2. y is the maximum common prefix, ignoring case, among all candidates
That's what is guaranteed by the semantics, so our code already does
that (barring bugs).
> 3. y is the *exact* (including case) prefix of at least one of the
> candidates
We could try that, indeed. It still satisfies the constraint
I described as "conservative", and it wouldn't cost extra
efforts either.
If someone wants to try that, feel free to do so, but I personally would
prefer if we only do that when all the matching candidates agree on
the capitalization.
BTW, we currently have the following tests in test/src/minibuffer-tests.el:
(ert-deftest test-try-completion-ignore-case ()
(let ((completion-ignore-case t))
(should (equal (try-completion "bar" '("bAr" "barfoo")) "bAr"))
(should (equal (try-completion "bar" '("bArfoo" "barbaz")) "bar"))
(should (equal (try-completion "bar" '("bArfoo" "barbaz"))
(try-completion "bar" '("barbaz" "bArfoo"))))
;; bug#11339
(should (equal (try-completion "baz" '("baz" "bAz")) "baz")) ;And not `t'!
(should (equal (try-completion "baz" '("bAz" "baz"))
(try-completion "baz" '("baz" "bAz"))))))
-- Stefan
next prev parent reply other threads:[~2020-10-28 16:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 15:44 bug#39484: 26.3; try-completion bug Wanrong Lin
2020-10-27 18:42 ` Lars Ingebrigtsen
2020-10-27 19:08 ` Andreas Schwab
2020-10-27 19:17 ` Lars Ingebrigtsen
2020-10-27 20:17 ` Wanrong Lin
2020-10-27 20:28 ` Andreas Schwab
2020-10-27 20:44 ` Wanrong Lin
2020-10-27 21:21 ` Andreas Schwab
2020-10-28 0:44 ` Wanrong Lin
2020-10-28 0:47 ` Wanrong Lin
2020-10-28 0:57 ` Wanrong Lin
2020-10-28 7:51 ` Andreas Schwab
2020-10-28 9:35 ` Lars Ingebrigtsen
2020-10-28 9:42 ` Andreas Schwab
2020-10-28 9:50 ` Lars Ingebrigtsen
2020-10-28 9:56 ` Andreas Schwab
2020-10-28 11:16 ` Lars Ingebrigtsen
2020-10-28 11:44 ` Andreas Schwab
2020-10-28 12:59 ` Wanrong Lin
2020-10-28 14:45 ` Stefan Monnier
2020-10-28 15:47 ` Wanrong Lin
2020-10-28 16:34 ` Stefan Monnier [this message]
2022-04-23 13:17 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1rhigwzh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=39484@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=schwab@linux-m68k.org \
--cc=wrglin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).