From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#45098: 28.0.50; gnu-elpa: if user says `no' to install package, it aborts the previous function invoked Date: Tue, 08 Dec 2020 09:22:18 -0500 Message-ID: References: <87zh2pfw5k.fsf@gnus.org> <87h7owjsh2.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20372"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Jean Louis , 45098@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 08 15:23:42 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmdu2-0005DZ-2w for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Dec 2020 15:23:42 +0100 Original-Received: from localhost ([::1]:35272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmdu0-0003yx-1z for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Dec 2020 09:23:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmdtR-0003hQ-6e for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 09:23:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmdtO-0005Xk-98 for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 09:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmdtO-0000GM-5d for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 09:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Dec 2020 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45098 X-GNU-PR-Package: emacs Original-Received: via spool by 45098-submit@debbugs.gnu.org id=B45098.1607437347951 (code B ref 45098); Tue, 08 Dec 2020 14:23:02 +0000 Original-Received: (at 45098) by debbugs.gnu.org; 8 Dec 2020 14:22:27 +0000 Original-Received: from localhost ([127.0.0.1]:57037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmdsp-0000FH-FV for submit@debbugs.gnu.org; Tue, 08 Dec 2020 09:22:27 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmdsn-0000F4-QC for 45098@debbugs.gnu.org; Tue, 08 Dec 2020 09:22:26 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9AC2980F3E; Tue, 8 Dec 2020 09:22:20 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4F9EB809A7; Tue, 8 Dec 2020 09:22:19 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1607437339; bh=QmFoIdwna+f/XusVSU3itlDj5aqBWpj8tsVCg61m6hs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BbVmIlLey0oONmdRQB3VNuK3JUtllpwBtC46ClDhrwTsaU/O5NvxtL1z++gLI2kcJ 75iJ4wCRReC4HUvFqBS2LGvdnwOruqWdP0PX8MLDDsmDsubSUxl9NadTH/Mjb5+1rz dIs6FJ5fOlAKVCa/1LLRhqWkyEM2M+uLQiLQmy7lbBIjeKan0jrMelkiGWJjyW6ME3 grFjtjAM/HKI+TZXppQvnMVAbrwvks5Lzq2ra7gq50EWiYAQJU6eZN51hl7FbRxvce nslZNalzTWxSR4sCjAMa+k75OoJJwZR7m7Kdg4ZEFb7v7WtOUUUqXSeJ7CMjPtCNP8 hioMzPetMzjNA== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 21F1F120314; Tue, 8 Dec 2020 09:22:19 -0500 (EST) In-Reply-To: <87h7owjsh2.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 08 Dec 2020 15:13:45 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195343 Archived-At: >> Problem (2) is largely unsolvable on `gnu-elpa`s side. >> Basically, the code in `sql-indent-enable` in sql.el does: >> >> (when (fboundp 'sqlind-minor-mode) >> (sqlind-minor-mode (if sql-use-indent-support +1 -1))) >> >> With `gnu-elpa` installed, `sqlind-minor-mode` is defined (as an >> autoloaded function), so we call it which in turns loads `gnu-elpa.el`, >> but from there we can't "uncall" the function. We could signal >> a different error than "Abort", and then change the call so it just >> ignores such errors, or we could have a special hack in `gnu-elpa` for >> `sqlind-minor-mode` such that when the user decides not to >> install the package we install a dummy version of the function which >> does nothing (and then undefines the function), but I'm not sure it's >> worth the trouble. > > Couldn't gnu-elpa just make sqlind-minor-mode into `indentity' (or > something similar) in these cases? You're thinking `ignore`, I suspect, and yes that's what I referred to with "a dummy version of the function which does nothing". Stefan