unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
@ 2022-01-07  8:38 Philipp Stephani
  2022-01-09 20:17 ` Michael Heerdegen
  2022-01-11 17:30 ` Philipp Stephani
  0 siblings, 2 replies; 11+ messages in thread
From: Philipp Stephani @ 2022-01-07  8:38 UTC (permalink / raw)
  To: 53068


Visit the file lisp/json.el, navigate to the `json-advance' inline
function, and hit C-u C-M-x.  This fails with a backtrace:

Debugger entered--Lisp error: (void-function backquote-form)
  backquote-form((((forward-char ,n)) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958))
  #f(compiled-function (head cursor) #<bytecode 0x1918f171823d32ac>)(inline-quote (((forward-char ,n)) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958))
  edebug-list-form((((forward-char ,n)) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958))
  edebug-form((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959))
  edebug-match-form((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959))
  edebug-match-symbol((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) form)
  edebug-match-one-spec((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) form)
  edebug-match-specs((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (form) #f(compiled-function (c s rh) #<bytecode -0x1c9964082b0c95b6>))
  edebug-&optional-wrapper((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (form) #f(compiled-function (c s rh) #<bytecode -0x1c9964082b0c95b6>))
  #f(compiled-function (_ cursor specs) #<bytecode 0x9a39e71a2be8e1d>)(&rest (((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (form))
  apply(#f(compiled-function (_ cursor specs) #<bytecode 0x9a39e71a2be8e1d>) &rest ((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (form)))
  edebug--match-&-spec-op(&rest (((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (form))
  edebug-match-specs((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (&rest form) edebug-match-specs)
  edebug-match((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (&rest form))
  edebug-match-def-body((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959))
  edebug-match-symbol((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) def-body)
  edebug-match-one-spec((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) def-body)
  edebug-match-specs((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (def-body) edebug-match-specs)
  edebug-match-specs((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) ([&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body) edebug-match-specs)
  edebug-match-specs((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) ([&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body) edebug-match-specs)
  edebug-match-specs((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (lambda-doc [&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body) edebug-match-specs)
  edebug-match-specs((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (lambda-list lambda-doc [&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body) edebug-match-specs)
  edebug-match-specs((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) (name lambda-list lambda-doc [&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body) edebug-match-specs)
  edebug-match-specs((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) ("define-inline" name lambda-list lambda-doc [&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body) edebug-match-specs)
  edebug-match-sublist((((inline-quote (forward-char ,n))) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959) ("define-inline" name lambda-list lambda-doc [&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body))
  edebug-match-list((((define-inline json-advance (&optional n) "Advance N characters forward, or 1 character if N ..." (inline-quote (forward-char ,n)))) (8734 (8735 . 8748) (8749 . 8761) (8762 (8763 . 8772) (8773 . 8774) . 8775) (8778 . 8923) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959)) ("define-inline" name lambda-list lambda-doc [&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body))
  edebug-match-one-spec((((define-inline json-advance (&optional n) "Advance N characters forward, or 1 character if N ..." (inline-quote (forward-char ,n)))) (8734 (8735 . 8748) (8749 . 8761) (8762 (8763 . 8772) (8773 . 8774) . 8775) (8778 . 8923) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959)) ("define-inline" name lambda-list lambda-doc [&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body))
  edebug-match-specs((((define-inline json-advance (&optional n) "Advance N characters forward, or 1 character if N ..." (inline-quote (forward-char ,n)))) (8734 (8735 . 8748) (8749 . 8761) (8762 (8763 . 8772) (8773 . 8774) . 8775) (8778 . 8923) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959)) (("define-inline" name lambda-list lambda-doc [&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body)) edebug-match-specs)
  edebug-match((((define-inline json-advance (&optional n) "Advance N characters forward, or 1 character if N ..." (inline-quote (forward-char ,n)))) (8734 (8735 . 8748) (8749 . 8761) (8762 (8763 . 8772) (8773 . 8774) . 8775) (8778 . 8923) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959)) (("define-inline" name lambda-list lambda-doc [&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body)))
  edebug-make-form-wrapper((((define-inline json-advance (&optional n) "Advance N characters forward, or 1 character if N ..." (inline-quote (forward-char ,n)))) (8734 (8735 . 8748) (8749 . 8761) (8762 (8763 . 8772) (8773 . 8774) . 8775) (8778 . 8923) (8926 (8927 . 8939) (8940 (8941 . 8953) (8954 (8954 . 8955) (8955 . 8956) . 8956) . 8957) . 8958) . 8959)) 8734 8958 (("define-inline" name lambda-list lambda-doc [&optional ("declare" def-declarations)] [&optional ("interactive" &optional [&or stringp def-form] &rest symbolp)] def-body)))
  edebug-read-and-maybe-wrap-form1()
  edebug-read-and-maybe-wrap-form()
  edebug--read(read #<buffer json.el>)
  apply(edebug--read read #<buffer json.el>)
  #f(advice-wrapper :around read edebug--read)(#<buffer json.el>)
  elisp--eval-defun()
  #f(compiled-function (edebug-it) "Evaluate the top-level form containing point, or after point.\n\nIf the current defun is actually a call to `defvar' or `defcustom',\nevaluating it this way resets the variable using its initial value\nexpression (using the defcustom's :set function if there is one), even\nif the variable already has some other value.  (Normally `defvar' and\n`defcustom' do not alter the value if there already is one.)  In an\nanalogous way, evaluating a `defface' overrides any customizations of\nthe face, so that it becomes defined exactly as the `defface' expression\nsays.\n\nIf `eval-expression-debug-on-error' is non-nil, which is the default,\nthis command arranges for all errors to enter the debugger.\n\nWith a prefix argument, instrument the code for Edebug.\n\nIf acting on a `defun' for FUNCTION, and the function was\ninstrumented, `Edebug: FUNCTION' is printed in the echo area.  If not\ninstrumented, just FUNCTION is printed.\n\nIf not acting on a `defun', the result of evaluation is displayed in\nthe echo area.  This display is controlled by the variables\n`eval-expression-print-length' and `eval-expression-print-level',\nwhich see." (interactive "P") #<bytecode -0x144badc3f8c191f7>)(nil)
  edebug--eval-defun(#f(compiled-function (edebug-it) "Evaluate the top-level form containing point, or after point.\n\nIf the current defun is actually a call to `defvar' or `defcustom',\nevaluating it this way resets the variable using its initial value\nexpression (using the defcustom's :set function if there is one), even\nif the variable already has some other value.  (Normally `defvar' and\n`defcustom' do not alter the value if there already is one.)  In an\nanalogous way, evaluating a `defface' overrides any customizations of\nthe face, so that it becomes defined exactly as the `defface' expression\nsays.\n\nIf `eval-expression-debug-on-error' is non-nil, which is the default,\nthis command arranges for all errors to enter the debugger.\n\nWith a prefix argument, instrument the code for Edebug.\n\nIf acting on a `defun' for FUNCTION, and the function was\ninstrumented, `Edebug: FUNCTION' is printed in the echo area.  If not\ninstrumented, just FUNCTION is printed.\n\nIf not acting on a `defun', the result of evaluation is displayed in\nthe echo area.  This display is controlled by the variables\n`eval-expression-print-length' and `eval-expression-print-level',\nwhich see." (interactive "P") #<bytecode -0x144badc3f8c191f7>) t)
  apply(edebug--eval-defun #f(compiled-function (edebug-it) "Evaluate the top-level form containing point, or after point.\n\nIf the current defun is actually a call to `defvar' or `defcustom',\nevaluating it this way resets the variable using its initial value\nexpression (using the defcustom's :set function if there is one), even\nif the variable already has some other value.  (Normally `defvar' and\n`defcustom' do not alter the value if there already is one.)  In an\nanalogous way, evaluating a `defface' overrides any customizations of\nthe face, so that it becomes defined exactly as the `defface' expression\nsays.\n\nIf `eval-expression-debug-on-error' is non-nil, which is the default,\nthis command arranges for all errors to enter the debugger.\n\nWith a prefix argument, instrument the code for Edebug.\n\nIf acting on a `defun' for FUNCTION, and the function was\ninstrumented, `Edebug: FUNCTION' is printed in the echo area.  If not\ninstrumented, just FUNCTION is printed.\n\nIf not acting on a `defun', the result of evaluation is displayed in\nthe echo area.  This display is controlled by the variables\n`eval-expression-print-length' and `eval-expression-print-level',\nwhich see." (interactive "P") #<bytecode -0x144badc3f8c191f7>) t)
  eval-defun(t)
  eval-defun((4))
  funcall-interactively(eval-defun (4))
  call-interactively(eval-defun nil nil)
  command-execute(eval-defun)

This is a regression from Emacs 27 and should therefore be fixed on the
release branch.


In GNU Emacs 28.0.90 (build 12, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
 of 2022-01-05
Repository revision: c0cfbca311e6e07e9f8b9c1c9d0e2fe9792cd08c
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux rodete

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking=all --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP
SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LC_TIME: en_DK.utf8
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug sendmail phst skeleton edmacro kmacro
pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util url-parse url-vars mailcap rx
message rmc dired dired-loaddefs rfc822 mml mml-sec epa derived epg
rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache json map
time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047
rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils
mailheader gnutls puny elp dbus xml subr-x seq byte-opt gv bytecomp
byte-compile cconv compile text-property-search comint ansi-color ring
cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 69569 7335)
 (symbols 48 8528 3)
 (strings 32 24812 2251)
 (string-bytes 1 802359)
 (vectors 16 15668)
 (vector-slots 8 207469 19157)
 (floats 8 29 44)
 (intervals 56 228 0)
 (buffers 992 11))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
  2022-01-07  8:38 bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions Philipp Stephani
@ 2022-01-09 20:17 ` Michael Heerdegen
  2022-01-09 20:49   ` Michael Heerdegen
  2022-01-11 17:30 ` Philipp Stephani
  1 sibling, 1 reply; 11+ messages in thread
From: Michael Heerdegen @ 2022-01-09 20:17 UTC (permalink / raw)
  To: Philipp Stephani; +Cc: 53068

Philipp Stephani <p.stephani2@gmail.com> writes:

> Visit the file lisp/json.el, navigate to the `json-advance' inline
> function, and hit C-u C-M-x.  This fails [...]

The culprit seems to be the edebug spec of `inline-quote' (that macro is
called by `json-advance'), instead of being an inline function.

What would be an appropriate edebug spec for `inline-quote'?  The old
one doesn't seem to be valid any more.

Michael.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
  2022-01-09 20:17 ` Michael Heerdegen
@ 2022-01-09 20:49   ` Michael Heerdegen
  2022-01-10  6:52     ` Michael Heerdegen
  2022-01-12 21:16     ` Philipp Stephani
  0 siblings, 2 replies; 11+ messages in thread
From: Michael Heerdegen @ 2022-01-09 20:49 UTC (permalink / raw)
  To: Philipp Stephani; +Cc: 53068

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Philipp Stephani <p.stephani2@gmail.com> writes:
>
> > Visit the file lisp/json.el, navigate to the `json-advance' inline
> > function, and hit C-u C-M-x.  This fails [...]
>
> The culprit seems to be the edebug spec of `inline-quote' (that macro is
> called by `json-advance')

Should the edebug-spec of `inline-quote' be (backquote-form) instead of
backquote-form?  AFAIU that's what `\`' seems to use.

Michael.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
  2022-01-09 20:49   ` Michael Heerdegen
@ 2022-01-10  6:52     ` Michael Heerdegen
  2022-01-12 21:16     ` Philipp Stephani
  1 sibling, 0 replies; 11+ messages in thread
From: Michael Heerdegen @ 2022-01-10  6:52 UTC (permalink / raw)
  To: 53068; +Cc: Gemini Lasswell, Lars Ingebrigtsen

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Michael Heerdegen <michael_heerdegen@web.de> writes:
>
> > Philipp Stephani <p.stephani2@gmail.com> writes:
> >
> > > Visit the file lisp/json.el, navigate to the `json-advance' inline
> > > function, and hit C-u C-M-x.  This fails [...]
> >
> > The culprit seems to be the edebug spec of `inline-quote' (that macro is
> > called by `json-advance')
>
> Should the edebug-spec of `inline-quote' be (backquote-form) instead of
> backquote-form?  AFAIU that's what `\`' seems to use.

Whereby - this had been changed for fixing bug#31051, so it seems this
once worked?

TIA,

Michael.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
  2022-01-07  8:38 bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions Philipp Stephani
  2022-01-09 20:17 ` Michael Heerdegen
@ 2022-01-11 17:30 ` Philipp Stephani
  2022-01-11 18:38   ` Eli Zaretskii
  1 sibling, 1 reply; 11+ messages in thread
From: Philipp Stephani @ 2022-01-11 17:30 UTC (permalink / raw)
  To: 53068

Am Fr., 7. Jan. 2022 um 09:44 Uhr schrieb Philipp Stephani
<p.stephani2@gmail.com>:
>
>
> Visit the file lisp/json.el, navigate to the `json-advance' inline
> function, and hit C-u C-M-x.  This fails with a backtrace:

git bisect says the following commit is the culprit:

commit d1be48fdedabb451d5c6cf315fd5f09a632e771f
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Fri Feb 12 19:28:25 2021 -0500

    Edebug: Overload `edebug-form-spec` even less





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
  2022-01-11 17:30 ` Philipp Stephani
@ 2022-01-11 18:38   ` Eli Zaretskii
  0 siblings, 0 replies; 11+ messages in thread
From: Eli Zaretskii @ 2022-01-11 18:38 UTC (permalink / raw)
  To: Philipp Stephani, Stefan Monnier; +Cc: 53068

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Tue, 11 Jan 2022 18:30:44 +0100
> 
> Am Fr., 7. Jan. 2022 um 09:44 Uhr schrieb Philipp Stephani
> <p.stephani2@gmail.com>:
> >
> >
> > Visit the file lisp/json.el, navigate to the `json-advance' inline
> > function, and hit C-u C-M-x.  This fails with a backtrace:
> 
> git bisect says the following commit is the culprit:
> 
> commit d1be48fdedabb451d5c6cf315fd5f09a632e771f
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Date:   Fri Feb 12 19:28:25 2021 -0500
> 
>     Edebug: Overload `edebug-form-spec` even less

Stefan, any comments?





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
  2022-01-09 20:49   ` Michael Heerdegen
  2022-01-10  6:52     ` Michael Heerdegen
@ 2022-01-12 21:16     ` Philipp Stephani
  2022-01-13 11:57       ` Philipp Stephani
  1 sibling, 1 reply; 11+ messages in thread
From: Philipp Stephani @ 2022-01-12 21:16 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: 53068

Am So., 9. Jan. 2022 um 21:49 Uhr schrieb Michael Heerdegen
<michael_heerdegen@web.de>:
>
> Michael Heerdegen <michael_heerdegen@web.de> writes:
>
> > Philipp Stephani <p.stephani2@gmail.com> writes:
> >
> > > Visit the file lisp/json.el, navigate to the `json-advance' inline
> > > function, and hit C-u C-M-x.  This fails [...]
> >
> > The culprit seems to be the edebug spec of `inline-quote' (that macro is
> > called by `json-advance')
>
> Should the edebug-spec of `inline-quote' be (backquote-form) instead of
> backquote-form?

I guess so.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
  2022-01-12 21:16     ` Philipp Stephani
@ 2022-01-13 11:57       ` Philipp Stephani
  2022-01-13 12:40         ` Eli Zaretskii
  2022-01-14 20:22         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 2 replies; 11+ messages in thread
From: Philipp Stephani @ 2022-01-13 11:57 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: 53068

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

Am Mi., 12. Jan. 2022 um 22:16 Uhr schrieb Philipp Stephani
<p.stephani2@gmail.com>:
>
> Am So., 9. Jan. 2022 um 21:49 Uhr schrieb Michael Heerdegen
> <michael_heerdegen@web.de>:
> >
> > Michael Heerdegen <michael_heerdegen@web.de> writes:
> >
> > > Philipp Stephani <p.stephani2@gmail.com> writes:
> > >
> > > > Visit the file lisp/json.el, navigate to the `json-advance' inline
> > > > function, and hit C-u C-M-x.  This fails [...]
> > >
> > > The culprit seems to be the edebug spec of `inline-quote' (that macro is
> > > called by `json-advance')
> >
> > Should the edebug-spec of `inline-quote' be (backquote-form) instead of
> > backquote-form?
>
> I guess so.

Any objections to installing the following patch on the emacs-28 branch?

[-- Attachment #2: 0001-Fix-Edebug-specification-for-inline-functions-Bug-53.patch --]
[-- Type: text/x-patch, Size: 1814 bytes --]

From ec1ce1dbddd6196bbffdfb32d63d4bb1a13010ea Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Thu, 13 Jan 2022 12:55:06 +0100
Subject: [PATCH] Fix Edebug specification for inline functions (Bug#53068).

* lisp/emacs-lisp/inline.el (inline-quote): Fix Edebug specification.

* test/lisp/emacs-lisp/edebug-tests.el (edebug-tests-inline): New unit
test.
---
 lisp/emacs-lisp/inline.el            |  2 +-
 test/lisp/emacs-lisp/edebug-tests.el | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/inline.el b/lisp/emacs-lisp/inline.el
index 963e117ff3..de0112db63 100644
--- a/lisp/emacs-lisp/inline.el
+++ b/lisp/emacs-lisp/inline.el
@@ -71,7 +71,7 @@
 
 (defmacro inline-quote (_exp)
   "Similar to backquote, but quotes code and only accepts , and not ,@."
-  (declare (debug backquote-form))
+  (declare (debug (backquote-form)))
   (error "inline-quote can only be used within define-inline"))
 
 (defmacro inline-const-p (_exp)
diff --git a/test/lisp/emacs-lisp/edebug-tests.el b/test/lisp/emacs-lisp/edebug-tests.el
index 92f63ec788..4aae2870a3 100644
--- a/test/lisp/emacs-lisp/edebug-tests.el
+++ b/test/lisp/emacs-lisp/edebug-tests.el
@@ -1093,5 +1093,15 @@ edebug-tests-duplicate-&define
               (edebug-new-definition name))))
       (should-error (eval-buffer) :type 'invalid-read-syntax))))
 
+(ert-deftest edebug-tests-inline ()
+  "Check that Edebug can instrument inline functions (Bug#53068)."
+  (with-temp-buffer
+    (print '(define-inline edebug-tests-inline (arg)
+              (inline-quote ,arg))
+           (current-buffer))
+    (let ((edebug-all-defs t)
+          (edebug-initial-mode 'Go-nonstop))
+      (eval-buffer))))
+
 (provide 'edebug-tests)
 ;;; edebug-tests.el ends here
-- 
2.34.1.703.g22d0c6ccf7-goog


^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
  2022-01-13 11:57       ` Philipp Stephani
@ 2022-01-13 12:40         ` Eli Zaretskii
  2022-01-13 13:31           ` Philipp Stephani
  2022-01-14 20:22         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 1 reply; 11+ messages in thread
From: Eli Zaretskii @ 2022-01-13 12:40 UTC (permalink / raw)
  To: Philipp Stephani; +Cc: michael_heerdegen, 53068

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Thu, 13 Jan 2022 12:57:34 +0100
> Cc: 53068@debbugs.gnu.org
> 
> > > Should the edebug-spec of `inline-quote' be (backquote-form) instead of
> > > backquote-form?
> >
> > I guess so.
> 
> Any objections to installing the following patch on the emacs-28 branch?

No objections.  Please go ahead, and thanks.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
  2022-01-13 12:40         ` Eli Zaretskii
@ 2022-01-13 13:31           ` Philipp Stephani
  0 siblings, 0 replies; 11+ messages in thread
From: Philipp Stephani @ 2022-01-13 13:31 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Michael Heerdegen, 53068-done

Am Do., 13. Jan. 2022 um 13:40 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Thu, 13 Jan 2022 12:57:34 +0100
> > Cc: 53068@debbugs.gnu.org
> >
> > > > Should the edebug-spec of `inline-quote' be (backquote-form) instead of
> > > > backquote-form?
> > >
> > > I guess so.
> >
> > Any objections to installing the following patch on the emacs-28 branch?
>
> No objections.  Please go ahead, and thanks.

Thanks, done with commit 34ca4ff9a52d38250f70f578fd045490b4eef4f9.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions
  2022-01-13 11:57       ` Philipp Stephani
  2022-01-13 12:40         ` Eli Zaretskii
@ 2022-01-14 20:22         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 0 replies; 11+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-01-14 20:22 UTC (permalink / raw)
  To: Philipp Stephani; +Cc: Michael Heerdegen, 53068

> Any objections to installing the following patch on the emacs-28 branch?

That looks right to me, thanks,


        Stefan






^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-01-14 20:22 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-07  8:38 bug#53068: 28.0.90; Emacs 28 regression: Can't edebug inline functions Philipp Stephani
2022-01-09 20:17 ` Michael Heerdegen
2022-01-09 20:49   ` Michael Heerdegen
2022-01-10  6:52     ` Michael Heerdegen
2022-01-12 21:16     ` Philipp Stephani
2022-01-13 11:57       ` Philipp Stephani
2022-01-13 12:40         ` Eli Zaretskii
2022-01-13 13:31           ` Philipp Stephani
2022-01-14 20:22         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-11 17:30 ` Philipp Stephani
2022-01-11 18:38   ` Eli Zaretskii

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).