bug#58479: 29.0.50; [feature/noverlay] Displaced overlays in notmuch search buffers after refreshing

[Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

> What I see is:
>
> 1. M-x my-b58479
> 2. Hell<point>...rld!
>
> M-x my-dump-overlays
>
> Buffer #<buffer *b58479*> has 2 overlays.
>
> #<overlay from 1 to 15 in *b58479*>
> (window #<window 68 on *b58479*> face hl-line priority -50)
>
> #<overlay from 5 to 10 in *b58479*>
> (invisible ellipsis)
>
> 3. C-d (5 times)
> 4. Hell...
>
> "rld!" disappears!

Thanks, I have fixed this specific problem with the patch below.
Let's hope it also fixes your original issue with notmuch.


        Stefan


diff --git a/src/textprop.c b/src/textprop.c
index 04fae528097..b34246f5bc7 100644
--- a/src/textprop.c
+++ b/src/textprop.c
@@ -649,7 +649,8 @@ get_char_property_and_overlay (Lisp_Object position, register Lisp_Object prop,
 	  Lisp_Object tem = Foverlay_get (node->data, prop);
           struct sortvec *this;
 
-	  if (NILP (tem) || (w && ! overlay_matches_window (w, node->data)))
+	  if (NILP (tem) || node->end < pos + 1
+	      || (w && ! overlay_matches_window (w, node->data)))
 	    continue;
 
           this = (result == items ? items + 1 : items);