From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59347: 29.0.50; `:family` face setting ignored Date: Fri, 18 Nov 2022 15:55:43 -0500 Message-ID: References: <83bkp4bfqf.fsf@gnu.org> <83wn7s9txp.fsf@gnu.org> <83pmdk9pat.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36645"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59347@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 21:56:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow8PI-0009GQ-GZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 21:56:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow8P8-0003De-4H; Fri, 18 Nov 2022 15:56:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow8P4-0003DL-IM for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 15:56:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow8P3-0006Nu-OC for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 15:56:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow8P3-0007aF-In for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 15:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 20:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59347 X-GNU-PR-Package: emacs Original-Received: via spool by 59347-submit@debbugs.gnu.org id=B59347.166880495529138 (code B ref 59347); Fri, 18 Nov 2022 20:56:01 +0000 Original-Received: (at 59347) by debbugs.gnu.org; 18 Nov 2022 20:55:55 +0000 Original-Received: from localhost ([127.0.0.1]:38412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow8Ow-0007Zt-Jq for submit@debbugs.gnu.org; Fri, 18 Nov 2022 15:55:54 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow8Ou-0007Zh-5j for 59347@debbugs.gnu.org; Fri, 18 Nov 2022 15:55:53 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BC2091000EF; Fri, 18 Nov 2022 15:55:46 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2E3ED1000C3; Fri, 18 Nov 2022 15:55:45 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1668804945; bh=MUjZ/4F7I0yCbN0B0fZKuNWL97VxYF7bM7DtTM0VfXs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pHlvItaAm1CQUd8JOQmlMKLGf++sUDlRDgcvai2UBBaVyBnhn2fUoAm9Yt4Mr6BZh c8AzKM8Ch1wpdlA1XtdasW0oDxV2CZOofQkitfc7Emgrq9AetKnf679VnVebNMqDB6 mmzuOCg4xvqAdBXxtPRUQa+L8iuQOaKoIuBVo9QcjK66qeKne2gqdN5uuRYHO1HeRX qV6qZSUnZBUFRscvkXOb2AveyPh90nxktnzZK6hvjtLu2JCQZloIYaIAUPrsrsPs7t LVKsv+1sIJzI19j8RUNJTxU8pe0RjPepkPK5+tt8C01uG/vFJ/8dLInalefpBD4i0e x7MwaIzNOBxYw== Original-Received: from pastel (unknown [104.247.241.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DD73312027C; Fri, 18 Nov 2022 15:55:44 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Fri, 18 Nov 2022 14:46:46 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248279 Archived-At: Stefan Monnier [2022-11-18 14:46:46] wrote: >> So this recipe is something that stopped working recently? > > I think so, yes (at least a similar setup in my config did). > >> Can you tell when, or bisect? > > Not sure when, yet. Presumably within the last 2 months. > I'll try to bisect. `git bisect` says: 6b1ed2f2c99a1c2da56c5f434570c438cad6576d is the first bad commit commit 6b1ed2f2c99a1c2da56c5f434570c438cad6576d Author: Eli Zaretskii Date: Sat Aug 27 13:13:48 2022 +0300 Fix antialias face attribute when text is scaled This restores the code we had in realize_gui_face before commit bf0d3f7. The problem described in bug#17973, which led to that commit, only happens if one uses a specific (misc-fixed) font family, not for the usual default fonts used by Emacs, and I'm not sure what's described there is a bug at all. At least for the purposes of text-scale-adjust, it makes no sense to ignore the foundry/family/adstyle of the original font, because we _want_ the same (or very similar) font, just of a different size. And likely in other use cases: if the :font attribute of a face specifies some font properties, we want to keep them all, not arbitrarily to ignore some of them. And definitely catering to an obscure use case such as the one cited in bug#17973 is NOT a good reason to make such radical changes in face-realization behavior. So I think backing out that part of commit bf0d3f7 is TRT, and if we decide that this causes bug#17973 in too many situations we care about, I'd rather find a kludge for that specific case than do that for every face realization. * src/xfaces.c (realize_gui_face): Preserve face attributes when text is scaled. This reverts part of the changes installed in commit bf0d3f7. (Bug#37473) src/xfaces.c | 27 +++------------------------ 1 file changed, 3 insertions(+), 24 deletions(-) :-( > The only way I know is to set font-log to nil before you do this, and > then look at the log. But I have never learned anything useful from > that log. :-( > Anyway, can you confirm that using other fonts instead of DejaVu Sans > does work? I just tried with `Noto Sans`, `Verdana`, `STIX`, and `Courier New` and none of them works (although they work with Emacs-28), so no I can't confirm. Stefan