From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point Date: Mon, 28 Nov 2022 17:50:03 -0500 Message-ID: References: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> <875yfcokhl.fsf@web.de> <87ilizsbjd.fsf@web.de> <87r0xnj9sl.fsf@ericabrahamsen.net> <874jui1z57.fsf@ericabrahamsen.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32476"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen , Sean Devlin , Helmut Eller , 59345@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 28 23:51:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozmy7-0008BD-Fz for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Nov 2022 23:51:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozmy2-00013k-6L; Mon, 28 Nov 2022 17:51:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozmxr-00010t-CS for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 17:51:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozmxq-0001dH-I9 for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 17:51:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozmxq-000823-7v for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 17:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 22:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59345 X-GNU-PR-Package: emacs Original-Received: via spool by 59345-submit@debbugs.gnu.org id=B59345.166967582330860 (code B ref 59345); Mon, 28 Nov 2022 22:51:02 +0000 Original-Received: (at 59345) by debbugs.gnu.org; 28 Nov 2022 22:50:23 +0000 Original-Received: from localhost ([127.0.0.1]:51426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozmxD-00081g-47 for submit@debbugs.gnu.org; Mon, 28 Nov 2022 17:50:23 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozmxB-00081a-Ht for 59345@debbugs.gnu.org; Mon, 28 Nov 2022 17:50:22 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8D07F440864; Mon, 28 Nov 2022 17:50:15 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2CF7244081B; Mon, 28 Nov 2022 17:50:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1669675810; bh=4dk/s81CKESm+SdiBtCDdM5CDS5neItBSNSOfGESCUo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Ox7USmghjjrOZhMoUoSWoHl7RmRDXQktnkNGVbITVvpn7jEQdzYK58eDVL6mWe2iQ WMLINdGeUPraEiafjsNmVmXXAxC9m+eRh3IalupaQYcM+8ShQhw4efPg6NlJwgfYZr 2pz6/y1z9SxxTmtavG3Z7V2uFhfO1/ut3ytxMZFedIrcdaPWd/VWl/COPuGCoeMfPG VtJIFJxMC/z8CnZAB/ywIARVCgeiagchlm1NYmiiY98FE0xiPnDomk1GxyGuj8foz+ zEkEC5PN4GDmT7e6emKRbkiv4xZq3fdhX+62DU+ynPjNHIs50onH28XijGkT9b/wX4 Dmauk2ZGxu92A== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D93BD120776; Mon, 28 Nov 2022 17:50:09 -0500 (EST) In-Reply-To: <874jui1z57.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 28 Nov 2022 14:40:20 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249348 Archived-At: > diff --git a/peg.el b/peg.el > index 0e4221eeb7..3f86a0bf19 100644 > --- a/peg.el > +++ b/peg.el > @@ -588,7 +588,9 @@ of PEG expressions, implicitly combined with `and'." > > (cl-defmethod peg--translate ((_ (eql syntax-class)) class) > (let ((probe (assoc class peg-syntax-classes))) > - (cond (probe `(looking-at ,(format "\\s%c" (cadr probe)))) > + (cond (probe `(when (looking-at ,(format "\\s%c" (cadr probe))) > + (forward-char) > + t) > (t (error "Invalid syntax class: %S\nMust be one of: %s" class > (mapcar #'car peg-syntax-classes)))))) > LGTM, Stefan