bug#58808: map-y-or-n-p should use read-key, not read-event

bug#58808: map-y-or-n-p should use read-key, not read-event

[meedstrom--- via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 4167 bytes --]

I found that map-y-or-n-p uses read-event, not read-key (still the case in master as of 2022-10-27).  Will you accept a patch if I try to rewrite it?

Background: I like to translate <escape> to C-g, so I can hit the physical Esc key.  It almost always works, except in two cases; when Emacs freezes, and when something calls map-y-or-n-p, like the command M-x save-some-buffers.

An additional concern is that while map-y-or-n-p is doing its thing, even the triplet ESC ESC ESC does not work!

Steps to reproduce:

1. Start Emacs -Q
2. Eval (define-key function-key-map (kbd "<escape>") (kbd "C-g"))
3. Edit some new file
4. Type C-x s to trigger save-some-buffers
5. Attempt to cancel by hitting the Escape key

--------

In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6)
 of 2022-09-12 built on frederik
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Arch Linux

Configured using:
 'configure --sysconfdir=/etc --prefix=/usr --libexecdir=/usr/lib
 --localstatedir=/var --with-cairo --with-harfbuzz --with-libsystemd
 --with-modules --with-x-toolkit=gtk3 'CFLAGS=-march=x86-64
 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2
 -Wformat -Werror=format-security -fstack-clash-protection
 -fcf-protection -g -ffile-prefix-map=/build/emacs/src=/usr/src/debug
 -flto=auto' 'LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
 -flto=auto''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE
XIM XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search seq byte-opt
gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils time-date subr-x cl-loaddefs
cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 51060 7072)
 (symbols 48 6633 1)
 (strings 32 18318 1832)
 (string-bytes 1 604358)
 (vectors 16 13634)
 (vector-slots 8 183648 9467)
 (floats 8 22 46)
 (intervals 56 242 0)
 (buffers 992 12))

[-- Attachment #2: Type: text/html, Size: 5289 bytes --]

bug#58808: map-y-or-n-p should use read-key, not read-event

[Eli Zaretskii]

> Date: Wed, 26 Oct 2022 23:59:46 +0000
> From: meedstrom--- via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> I found that map-y-or-n-p uses read-event, not read-key (still the case in master as of 2022-10-27).  Will you
> accept a patch if I try to rewrite it?
> 
> Background: I like to translate <escape> to C-g, so I can hit the physical Esc key.  It almost always works,
> except in two cases; when Emacs freezes, and when something calls map-y-or-n-p, like the command M-x
> save-some-buffers.
> 
> An additional concern is that while map-y-or-n-p is doing its thing, even the triplet ESC ESC ESC does not
> work!
> 
> Steps to reproduce:
> 
> 1. Start Emacs -Q
> 2. Eval (define-key function-key-map (kbd "<escape>") (kbd "C-g"))
> 3. Edit some new file
> 4. Type C-x s to trigger save-some-buffers
> 5. Attempt to cancel by hitting the Escape key

Isn't there some translation map that could help you?

Adding Stefan to CC, in case he has comments.

(I'd assume that map-y-or-n-p would work like y-or-n-p, including
support for y-or-n-p-use-read-key, but evidently it doesn't, which is
surprising, I think.)

bug#58808: map-y-or-n-p should use read-key, not read-event

[meedstrom--- via Bug reports for GNU Emacs, the Swiss army knife of text editors]

October 27, 2022 at 5:58 AM, "Eli Zaretskii" wrote:
 
> Isn't there some translation map that could help you?

I have tried the remap in all of these:

- input-decode-map
- key-translation-map
- function-key-map
- all of the above simultaneously

I don't mind letting C-g be a separate key just for unfreezing Emacs, but in all other cases it seems right for an Escape remap to Just Work.

Martin

bug#58808: map-y-or-n-p should use read-key, not read-event

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> I found that map-y-or-n-p uses read-event, not read-key (still the
>> case in master as of 2022-10-27).  Will you accept a patch if I try
>> to rewrite it?
[...]
> Isn't there some translation map that could help you?

No, `read-event` is the low-level function that gives access to the
actual untranslated events.  I think `map-y-or-n-p` should be changed
similarly to `y-or-n-p` to use either `read-key` or the minibuffer
(probably obeying `y-or-n-p-use-read-key`).


        Stefan

bug#58808: map-y-or-n-p should use read-key, not read-event

[Jeremy Bryant]

Stefan Monnier <monnier@iro.umontreal.ca> writes:
Hi Stefan,

In order to work on this, please could you confirm the suggested change
below from October is still the recommended one, to work on a patch
along the lines below?

Jeremy

>>> I found that map-y-or-n-p uses read-event, not read-key (still the
>>> case in master as of 2022-10-27).  Will you accept a patch if I try
>>> to rewrite it?
> [...]
>> Isn't there some translation map that could help you?
>
> No, `read-event` is the low-level function that gives access to the
> actual untranslated events.  I think `map-y-or-n-p` should be changed
> similarly to `y-or-n-p` to use either `read-key` or the minibuffer
> (probably obeying `y-or-n-p-use-read-key`).
>
>
>         Stefan

bug#58808: map-y-or-n-p should use read-key, not read-event

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> In order to work on this, please could you confirm the suggested change
> below from October is still the recommended one, to work on a patch
> along the lines below?

Nothing has changed in this regard, indeed, so my comment from last year
is still as valid as ever :-)


        Stefan