From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Eli Zaretskii <eliz@gnu.org>,
62847@debbugs.gnu.org, Gustavo Barros <gusbrs.2016@gmail.com>
Subject: bug#62847: 29.0.90; Propertized space in Org Agenda's mode-name
Date: Sat, 15 Apr 2023 09:21:35 -0400 [thread overview]
Message-ID: <jwv1qkljneu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87cz45e4b2.fsf@localhost> (Ihor Radchenko's message of "Sat, 15 Apr 2023 12:08:17 +0000")
> So, it really looks like compilation problem.
>
> I am now looking into Elisp manual
>
> 2.9 Mutability
>
> When similar constants occur as parts of a program, the Lisp
> interpreter might save time or space by reusing existing constants or
> their components. For example, ‘(eq "abc" "abc")’ returns ‘t’ if the
> interpreter creates only one instance of the string literal ‘"abc"’, and
> returns ‘nil’ if it creates two instances. Lisp programs should be
> written so that they work regardless of whether this optimization is in
> use.
>
> So, it should be a good idea to avoid setting text properties in string
> constants in general.
Indeed, since it modifies the object, it's "undefined behavior" territory.
> - (propertize "ALL" 'face 'org-agenda-structure-filter)
> + (propertize
> + (copy-sequence "ALL") ; Avoid modifying `eq' string constants.
> + 'face 'org-agenda-structure-filter)
`propertize` does not modify its string argument (it returns a new
string instead), so the `copy-sequence` here is a pure waste.
> - (propertize " " 'display category-icon)
> + (propertize
> + (copy-sequence " ") ; Avoid modifying `eq' " ".
> + 'display category-icon)
Same here.
> - (org-add-props " " (org-plist-delete (text-properties-at 0 x)
> - 'display)))
> + (org-add-props
> + (copy-sequence " ") ; Avoid modifying `eq' " ".
> + (org-plist-delete (text-properties-at 0 x)
> + 'display)))
This hunk fixes a real bug, OTOH.
Maybe you should use `(apply #'propertize` instead or `org-add-props`?
Stefan
next prev parent reply other threads:[~2023-04-15 13:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 23:04 bug#62847: 29.0.90; Propertized space in Org Agenda's mode-name Gustavo Barros
2023-04-15 9:38 ` Ihor Radchenko
2023-04-15 9:49 ` Eli Zaretskii
2023-04-15 10:02 ` Ihor Radchenko
2023-04-15 10:24 ` Eli Zaretskii
2023-04-15 10:40 ` Ihor Radchenko
2023-04-15 10:55 ` Eli Zaretskii
2023-04-15 11:28 ` Gustavo Barros
2023-04-15 11:44 ` Ihor Radchenko
2023-04-15 11:49 ` Gustavo Barros
2023-04-15 12:08 ` Ihor Radchenko
2023-04-15 13:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-04-16 11:23 ` Ihor Radchenko
2023-04-16 11:49 ` Gustavo Barros
2023-04-15 11:38 ` Eli Zaretskii
2023-04-15 11:44 ` Ihor Radchenko
2023-04-15 11:45 ` Eli Zaretskii
2023-04-15 13:15 ` Mattias Engdegård
2023-04-16 11:29 ` Ihor Radchenko
2023-04-16 12:02 ` Mattias Engdegård
2023-04-16 12:17 ` Ihor Radchenko
2023-04-16 12:58 ` Eli Zaretskii
2023-04-16 13:14 ` Ihor Radchenko
2023-04-16 14:43 ` Eli Zaretskii
2023-04-16 14:52 ` Ihor Radchenko
2023-04-16 15:17 ` Eli Zaretskii
2023-04-16 14:51 ` Mattias Engdegård
2023-04-16 14:53 ` Mattias Engdegård
2023-04-16 12:38 ` Daniel Mendler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1qkljneu.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=62847@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gusbrs.2016@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).