From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62732: 29.0.60; uniquify-trailing-separator-p affects any buffer whose name matches a dir in CWD Date: Mon, 10 Jul 2023 15:18:48 -0400 Message-ID: References: <87h6tpn8d5.fsf@catern.com> <87edotn7sx.fsf@catern.com> <87edlhm6wq.fsf@catern.com> <87o7kklf9c.fsf@catern.com> <83r0pf9b7d.fsf@gnu.org> <83fs5v8tsw.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7790"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: sbaugh@catern.com, 62732@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 10 21:19:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIwPh-0001lm-H5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Jul 2023 21:19:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qIwPa-0007gU-2s; Mon, 10 Jul 2023 15:19:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIwPX-0007dy-RT for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 15:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qIwPW-00041W-Jp for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 15:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qIwPW-0003to-2R for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 15:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jul 2023 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62732 X-GNU-PR-Package: emacs Original-Received: via spool by 62732-submit@debbugs.gnu.org id=B62732.168901673914976 (code B ref 62732); Mon, 10 Jul 2023 19:19:02 +0000 Original-Received: (at 62732) by debbugs.gnu.org; 10 Jul 2023 19:18:59 +0000 Original-Received: from localhost ([127.0.0.1]:49160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIwPS-0003tU-Po for submit@debbugs.gnu.org; Mon, 10 Jul 2023 15:18:59 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIwPQ-0003tC-3a for 62732@debbugs.gnu.org; Mon, 10 Jul 2023 15:18:57 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 665E5441813; Mon, 10 Jul 2023 15:18:50 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0575344180D; Mon, 10 Jul 2023 15:18:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689016729; bh=FWzeD3Nh7LBGb0SeBNf/J4zDSqYu4fbTvkdGHtRNcQs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PAvOEkSUzdtHNcgI8o3X+FPKD/bekkheVwx9AwQJXNP9z1+U8+JZIrBh0hWG8Q4yp etVXUGJLKqMtj2/gJNz8wfK3Pnbf+cpqE+ZjCKGjHIO4xslCIe8v4KrIOPvXZ4Bv3X DAJUr8dn6vbdUZgOLWz/grzHeczCA2kik14huGcNhfjWZh2YurJocpXP1OJswd5O8r PP+ENlTYLO00lbVMmGs04KV0dqw6xquwUNz3m+PrxU3S3gwBdsCjLGzA4FkrP16h8H 64XNO+sTGpq5avJBRILqsHVuyajFbdHBeReTwJPW2PK0tQE7OpKW+Pa/fjZiPygXoh o+7oc8E/0eylQ== Original-Received: from pastel (unknown [24.140.234.50]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D197612020D; Mon, 10 Jul 2023 15:18:48 -0400 (EDT) In-Reply-To: <83fs5v8tsw.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 10 Jul 2023 22:12:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264901 Archived-At: >> > Callers shouldn't know to much about the internals of the callee. >> >> Indeed: currently `create-file-buffer` doesn't pay attention to the file >> system at all, it just creates a buffer with a name based on the >> FILENAME that's passed. Spencer's patch just offers more control to the >> callers by making `create-file-buffer` respect the choice of the callers >> (whether they used a file name or a dire name, which is an important >> distinction in Emacs's file name APIs, not just here). >> >> There's no need for the callers to know about the internals of >> the callee. If they call `create-file-buffer` with /foo/bar/baz the >> buffer will be called "baz" and if they call it with /foo/bar/baz/ the >> buffer will be called "baz/" (depending on >> `uniquify-trailing-separator-p`, of course). >> It's the most natural/obvious semantics. > > Wasn't the fact that the trailing slash was absent part of the reason > for the bug this tries to fix? If so, then this is not just "if you > want it, use it", is it? No, `create-file-buffer` used to throw away the trailing slash, rather than make use of this information. Not sure why Dired bothered to remove the tailing slash when calling it, maybe because a long time ago `create-file-buffer` had a bug if the name had a trailing slash. Stefan