From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Date: Sat, 05 Aug 2023 18:53:48 -0400 Message-ID: References: <8B08E514-B2D5-48F5-BA90-4F5A9492F8F9@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11996"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 65017@debbugs.gnu.org, Eric Marsden To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 06 00:55:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSQAy-0002sB-F4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Aug 2023 00:55:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSQAo-0006fZ-VQ; Sat, 05 Aug 2023 18:55:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSQAo-0006fR-12 for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 18:55:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSQAn-0003lm-Ol for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 18:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSQAn-0001b6-L9 for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 18:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2023 22:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65017 X-GNU-PR-Package: emacs Original-Received: via spool by 65017-submit@debbugs.gnu.org id=B65017.16912760526073 (code B ref 65017); Sat, 05 Aug 2023 22:55:01 +0000 Original-Received: (at 65017) by debbugs.gnu.org; 5 Aug 2023 22:54:12 +0000 Original-Received: from localhost ([127.0.0.1]:58323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSQA0-0001Zt-2Q for submit@debbugs.gnu.org; Sat, 05 Aug 2023 18:54:12 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSQ9x-0001Ze-Qo for 65017@debbugs.gnu.org; Sat, 05 Aug 2023 18:54:10 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5E853444904; Sat, 5 Aug 2023 18:54:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1691276042; bh=ep1vweo6jfjlV46RxsM76NAtoNweD6JX9Rchk9AWT5s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iTmD9QyKu2cDqM4XGwL41KiqRGh9Ryp7wEv4eLa1AzqSiI7wVejQpyb3IAHjut2si +QFgpFeyU0LH8kixL4mDTMx64FtqnHWycaRtRTPZZHkw8Yt9CnztzAvMdf+L6LujA/ wLP7LLkNAmCzzPwILNcj/m0UTi2YviTMLekCDbsZwRWJgK6n1ORuNGWhOB6Ag36QPM tJX9YoH/mqCd3mo426f0ps7r/sFHVIRHUpWvC6rgmtOHBs/M+yMM4OFhPlFeob+YqR bbWc/2zxjYf1P8yky3SlCYRctr56ZyWVoWZ6kWj7T6rwZ8LGRGZtGtq4A9u5tXTwLd j821+oS+8EN4A== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C70054448FB; Sat, 5 Aug 2023 18:54:02 -0400 (EDT) Original-Received: from alfajor (unknown [190.16.213.142]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 73FFC120397; Sat, 5 Aug 2023 18:54:01 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Fri, 4 Aug 2023 13:22:58 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266823 Archived-At: >> I don't know why `symbols-with-pos-enabled` is non-nil at that point (I >> thought we only enabled it wile byte-compiling), .... > > This is not quite the case. symbols-with-pos-enabled gets erroneously > bound to t in internal-macroexpand-for-load (emacs-lisp/macroexp.el). Aha! > diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el > index b05aba3e1a7..ea838f5b7b2 100644 > --- a/lisp/emacs-lisp/macroexp.el > +++ b/lisp/emacs-lisp/macroexp.el > @@ -799,8 +799,7 @@ macroexp--debug-eager > > (defun internal-macroexpand-for-load (form full-p) > ;; Called from the eager-macroexpansion in readevalloop. > - (let ((symbols-with-pos-enabled t) > - (print-symbols-bare t)) > + (let ((print-symbols-bare t)) > (cond > ;; Don't repeat the same warning for every top-level element. > ((eq 'skip (car macroexp--pending-eager-loads)) form) Looks good to me. AFAICT this binding was added at some point where it seemed like a good idea but we later figured better places to do it, and we just didn't remove it because it seemed "harmless" (or because we just didn't think of it). > Stefan, it would still be nice for cl--labels-convert-cache to get > initialised each time it gets used. No, the problem is not initialization, as I pointed out. The problem is that this `eq` should not consider a symbol equal to a sympos *ever* (contrary to most other uses of `eq` in macros). Stefan