From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68246: 30.0.50; Add non-TS mode as extra parent of TS modes Date: Mon, 08 Jan 2024 19:52:01 -0500 Message-ID: References: <83edeww73j.fsf@gnu.org> <83o7dzvrmf.fsf@gnu.org> <838r53vlo5.fsf@gnu.org> <831qavvcbo.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40161"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , Eli Zaretskii , casouri@gmail.com, 68246@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 01:53:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rN0Mt-000AFI-MJ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 01:53:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rN0MU-00074L-Lx; Mon, 08 Jan 2024 19:52:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rN0MS-00073v-Bq for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 19:52:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rN0MS-0002Ay-3v for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 19:52:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rN0MY-00078L-D2 for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 19:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 00:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68246 X-GNU-PR-Package: emacs Original-Received: via spool by 68246-submit@debbugs.gnu.org id=B68246.170476154527360 (code B ref 68246); Tue, 09 Jan 2024 00:53:02 +0000 Original-Received: (at 68246) by debbugs.gnu.org; 9 Jan 2024 00:52:25 +0000 Original-Received: from localhost ([127.0.0.1]:37916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN0Lx-00077D-0c for submit@debbugs.gnu.org; Mon, 08 Jan 2024 19:52:25 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN0Ls-00076u-Vj for 68246@debbugs.gnu.org; Mon, 08 Jan 2024 19:52:24 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A67AD10009F; Mon, 8 Jan 2024 19:52:08 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1704761523; bh=r2BF6KyVuSHY6jptlQ3J7b52TTdM7Tm+Ix0c+yJoY18=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hT3Clj/8YdoUcbXDO78Uad+Vvexvd2bcS46efCgNnMDh2xfte9qztrr9opVg/uLab V3McZnjLEaAdvChwNaBGwTsWZTQpM/ohMWwBPFhoJrGFPYeUMdK0L2NcI5WiH+QnVP mkQnI3siTD4NC6oHfE5h/9hdx+dFGWOXkLYiv4qBpSJAsRKZCrwnY40NHnipMtnzNK HOl1ZCyPT/bYvMvkVUFIKlW03BYlA50bBjiWIkT8RDmEH5Q7M8jasnG2QoM9Q3OrWf +q0pZGIzGPHjd3xoDJjC1FcCeejG7OTF7FpJbDtaueVNAs/vwCsGdDA4v6tb4HhI4b /hoSs/jI0/M+A== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8610B10004C; Mon, 8 Jan 2024 19:52:03 -0500 (EST) Original-Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5443E120866; Mon, 8 Jan 2024 19:52:03 -0500 (EST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 9 Jan 2024 00:39:40 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277589 Archived-At: > BTW, in your patch, can you keep the whitespace of eglot-server-programs > or, alternatively, change that whitespace in a separate commit that changes > nothing else? I understand the current indentation is awful Exactly, it's awful and goes against our convention to stay within 80 columns. I'll make it a separate commit. > but I rely on Git history/vc-region-history a lot in the whole of > eglot.el Not sure how making it a separate commit will help. But following the conventions from the get-go would have avoided this specific instance of the problem :-) Stefan