unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: Ihor Radchenko <yantar92@posteo.net>, 68509@debbugs.gnu.org
Subject: bug#68509: 30.0.50; pcase-dolist matches backquote pattern incorrectly
Date: Mon, 19 Feb 2024 10:51:45 -0500	[thread overview]
Message-ID: <jwv1q98wjss.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <9bc2bd05-5fdb-9d5a-3d98-c344c7275027@gmail.com> (Jim Porter's message of "Tue, 16 Jan 2024 08:52:27 -0800")

>> Consider the following
>> (pcase-dolist (`(,(and (pred stringp) a) .
>> 		 ,(and (pred stringp) b))
>> 	       '(("TODO") ("DONE" . "a")))
>>    (warn "%S :: %S" a b))
>> Executing the above yields
>> ⛔ Warning (emacs): "TODO" :: nil
>> ⛔ Warning (emacs): "DONE" :: "a"
>> even though ("TODO") does not match the pattern.
>
> This isn't an issue with 'pcase-dolist', but rather a known/intentional
> limitation of 'pcase-let':

Indeed, I consider the above a pilot error.
`pcase-dolist` and `pcase-let` use Pcase patterns to do *destructuring*,
which is a different task than the one done by `pcase` (which decides
whether a value matches a pattern or not).

>> Each EXP should match (i.e. be of compatible structure) to its
>> respective PATTERN; a mismatch may signal an error or may go
>> undetected, binding variables to arbitrary values, such as nil.
> I do think we should fix it somehow though.  This behavior is
> extremely confusing, and as much as I'm a fan of 'pcase', I'm
> emphatically *not* a fan of how this part works.

I'm quite happy with the way it works when you use it as intended.
But I'm not really satisfied either with the way it behaves when the
coder doesn't understand its semantics, nor about the way we document
that semantics.

The difficulty in resolving this can be illustrated with the following
pattern:

    `(a . ,b)

This pattern leads to two tests: (consp VAL) and (eq 'a (car VAL)).
When destructuring, we want to throw away both tests (we want to throw
away most tests, except those needed to choose between two `or`
branches).

We could decide to emit a warning because we silently skip
the `eq` test, which would help the coders understand that the pattern
doesn't do what they think.
But emitting that same warning because we silently skip the `consp` test
would be really annoying because rewriting the pattern to avoid this
is impractical.

For a human, it's pretty easy to distinguish those two cases.  But it's
difficult to provide a precise definition that distinguishes those two cases.

We could also keep the tests and emit a warning or even an error when
they fail, but if that's the behavior you want, then you should
arguably use `pcase(-exhaustive)` instead.


        Stefan






  parent reply	other threads:[~2024-02-19 15:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16 15:07 bug#68509: 30.0.50; pcase-dolist matches backquote pattern incorrectly Ihor Radchenko
2024-01-16 16:52 ` Jim Porter
2024-01-16 18:43   ` Ihor Radchenko
2024-02-19 10:05     ` Ihor Radchenko
2024-02-19 12:59       ` Eli Zaretskii
2024-02-19 15:53       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-19 18:14         ` Ihor Radchenko
2024-02-20  2:41           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-20 13:40             ` Ihor Radchenko
2024-02-20 14:35               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-20 15:16                 ` Ihor Radchenko
2024-02-20 17:51                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-21 11:23                     ` Ihor Radchenko
2024-02-21 14:17                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-23 14:05                         ` Ihor Radchenko
2024-02-23 14:58                           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 13:28                             ` Ihor Radchenko
2024-02-24 14:57                               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-19 15:51   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-02-19 18:16     ` Ihor Radchenko
2024-02-20  2:46       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1q98wjss.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=68509@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).