From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ola x Nilsson Newsgroups: gmane.emacs.bugs Subject: bug#50175: 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x = (vc-doff) Date: Thu, 26 Aug 2021 08:14:23 +0200 Message-ID: References: <9109d282-192c-22ec-6010-4e1f3cc97d9e@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14273"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.8; emacs 28.0.50 Cc: "larsi@gnus.org" , "sds@gnu.org" , "50175-done@debbugs.gnu.org" <50175-done@debbugs.gnu.org> To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 26 08:15:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJ8fP-0003UA-UP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 08:15:12 +0200 Original-Received: from localhost ([::1]:34478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJ8fO-0003FK-7b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 02:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJ8fG-0003Et-KW for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 02:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJ8fG-0002b3-DF for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 02:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJ8fG-0008Db-81 for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 02:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ola x Nilsson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Aug 2021 06:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50175 X-GNU-PR-Package: emacs Original-Received: via spool by 50175-done@debbugs.gnu.org id=D50175.162995848031545 (code D ref 50175); Thu, 26 Aug 2021 06:15:02 +0000 Original-Received: (at 50175-done) by debbugs.gnu.org; 26 Aug 2021 06:14:40 +0000 Original-Received: from localhost ([127.0.0.1]:48179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJ8eq-0008Cd-7e for submit@debbugs.gnu.org; Thu, 26 Aug 2021 02:14:40 -0400 Original-Received: from smtp2.axis.com ([195.60.68.18]:53720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJ8ek-0008CK-Pr for 50175-done@debbugs.gnu.org; Thu, 26 Aug 2021 02:14:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1629958471; x=1661494471; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=H30Db4btAKF3NbB3aV8n2sivYn++QO8zFLf7OTof+E0=; b=kO5uE7kBJCBgUIvZHpvR3TpDkKjD0xikOCJwYM9xvExz2yxUhRNpHgnZ WcJFHKvZvDPfgpC8xF/z8ySA/2Ir5/MNv5yUHB+qZ7jOprxM0lF/3wNp+ i0z3FQL/tBtchx8es2kCQTPtsnT2P6p+iFcgqdQV+42KMqmAOLKmxISm5 kwvJXIYQs911S1VRZI6prgv9MqziU1HOCbgvWAUEzI9C4cZoBVkPcgx27 muhGquEVfaGvcwq1QVpEtOhiOo2H0nc9QdlNite6Gw+yKh7yd5xX0kccG ylxRIyUCj/u9O2T4tVPJ+hhSZPXbmLRH1gbKNKCjn8331nctpHyWHAUs4 g==; In-Reply-To: <9109d282-192c-22ec-6010-4e1f3cc97d9e@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212683 Archived-At: On Thu, Aug 26 2021, Dmitry Gutov wrote: > Hi! > > On 25.08.2021 18:45, Steingold wrote: >> Hi Ola, Lars, Dmitry, >> >>> * Ola x Nilsson [2021-08-25 15:26:34 +0200]: >>> >>> On Mon, Aug 23 2021, Steingold wrote: >>> >>>> when editing a remote file, vc-dir shows the*vc-dir* buffer correctly, >>>> but vc-diff in the same buffer fails: >>>> >>>> >>>> Same error on = (vc-diff) in the*vc-dir* buffer. >>>> >>>> I am pretty sure this is a regression from about 2-3 weeks ago. >>>> >>>> (vc-next-action also fails) >>> This is the result of the git literal pathspec prefix being added in a >>> non-tramp-aware way. See bug #39452. The commits in question are >>> >>> 3502321403 Fix regressions in the last change >>> 3572613550 Fix vc-git-state for filenames with wildcards >> I do have all these patches, but, alas, I still see the bug. >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39452 >> has no messages for 10 days, I hope it is being worked on... Sorry, I was not as clear as I should have been. The two commits above introduced the problem. Reverting them made vc-git work over tramp for me again. > We indeed applied a patch that's been lying around for a while and keep > finding regressions. > > Now I was curious to see how we generally avoid passing remote file > names (in Tramp syntax) to Git and other VCS, and it turns out > vc-do-command, which almost all calls go though, converts all file names > to relative ones. > > Which the new literal-pathspecs approach in vc-git conflicts with. I'm > still not loving the idea of a dynamic variable to enable/disable the > use of env var (fix for the problem we/I have met with the other > approach), but it's becoming increasingly attractive. > > That said, I've just pushed a fix (commit 2b62b2a019), please see how it > works for you. I did some light testing, and vc-diff and vc-annotate work for me now with git over tramp. -- Ola Nilsson