From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ola x Nilsson Newsgroups: gmane.emacs.bugs Subject: bug#50175: 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x = (vc-doff) Date: Wed, 25 Aug 2021 15:26:34 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25199"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, 50175@debbugs.gnu.org, dgutov@yandex.ru To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 25 15:27:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIsvw-0006JH-4y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 15:27:12 +0200 Original-Received: from localhost ([::1]:49482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIsvv-00051i-26 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 09:27:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIsvn-0004v5-28 for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 09:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIsvm-00036f-PU for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 09:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIsvm-0007s8-K2 for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 09:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ola x Nilsson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Aug 2021 13:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50175 X-GNU-PR-Package: emacs Original-Received: via spool by 50175-submit@debbugs.gnu.org id=B50175.162989801330243 (code B ref 50175); Wed, 25 Aug 2021 13:27:02 +0000 Original-Received: (at 50175) by debbugs.gnu.org; 25 Aug 2021 13:26:53 +0000 Original-Received: from localhost ([127.0.0.1]:46152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIsvY-0007rd-Jd for submit@debbugs.gnu.org; Wed, 25 Aug 2021 09:26:52 -0400 Original-Received: from smtp1.axis.com ([195.60.68.17]:30543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIsvS-0007rK-F6 for 50175@debbugs.gnu.org; Wed, 25 Aug 2021 09:26:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1629898002; x=1661434002; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=KqxvuFnYLjNGoiZhJWgTDtFqMU1I+Jp3xqzcaBGtypI=; b=iKO1ONYICt94vXyHVtGAq/p+BG4EkbsiJCMFxiDre01evtaVq9JmLZd/ pMasbTFK2QSw1Z+AUNpKJI2eQ2EBYsBYeW8y0k30WpJrmw08dk4Q7HRI/ KVZpgaxMNgWjeIhgZl61zDqxHIp9oLmQ2t0B8f+0gjhQv9Oj5BrARdKT8 8nwpmf3awCh7TEW3XSiTVyh8i75mI+peddvTODqfE8BeQfrzxwpt+rUPv Z36sSJ+3xg308Ee4QD/6O6asFzI1wc8/sCfQ+lI1NoLINHojSP0kvvEpL FO6MnGn1LvKdplFrz1WIWDkDWHV6hFsbUjQH0l0sgPLE07S0ak9ipEbPh w==; In-Reply-To: (Steingold's message of "Mon, 23 Aug 2021 18:09:14 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212628 Archived-At: On Mon, Aug 23 2021, Steingold wrote: > when editing a remote file, vc-dir shows the *vc-dir* buffer correctly, > but vc-diff in the same buffer fails: > > Debugger entered--Lisp error: (error "Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py") > signal(error ("Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py")) > error("Failed (%s): %s" "status 128" "git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py") > vc-do-command("*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") "--no-pager" "diff-index" "--exit-code" "-p" "HEAD" nil "--") > apply(vc-do-command "*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") ("--no-pager" "diff-index" "--exit-code" "-p" "HEAD" nil "--")) > vc-git-command("*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" "--exit-code" "-p" "HEAD" nil "--") > apply(vc-git-command "*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" "--exit-code" ("-p" "HEAD" nil "--")) > vc-git-diff(("/scp:remote:/path/file.py") nil nil "*vc-diff*" t) > apply(vc-git-diff (("/scp:remote:/path/file.py") nil nil "*vc-diff*" t)) > vc-call-backend(Git diff ("/scp:remote:/path/file.py") nil nil "*vc-diff*" t) > vc-diff-internal(t (Git ("/scp:remote:/path/file.py")) nil nil t) > vc-diff(nil t) > funcall-interactively(vc-diff nil t) > call-interactively(vc-diff nil nil) > command-execute(vc-diff) > > Same error on = (vc-diff) in the *vc-dir* buffer. > > I am pretty sure this is a regression from about 2-3 weeks ago. > > (vc-next-action also fails) This is the result of the git literal pathspec prefix being added in a non-tramp-aware way. See bug #39452. The commits in question are 3502321403 Fix regressions in the last change 3572613550 Fix vc-git-state for filenames with wildcards -- Ola Nilsson