From: Ola x Nilsson <ola.x.nilsson@axis.com>
To: <sds@gnu.org>
Cc: larsi@gnus.org, 50175@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#50175: 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x = (vc-doff)
Date: Wed, 25 Aug 2021 15:26:34 +0200 [thread overview]
Message-ID: <jwqbl5l1wqd.fsf@axis.com> (raw)
In-Reply-To: <lzlf4rizjp.fsf@3c22fb11fdab.ant.amazon.com> (Steingold's message of "Mon, 23 Aug 2021 18:09:14 -0400")
On Mon, Aug 23 2021, Steingold wrote:
> when editing a remote file, vc-dir shows the *vc-dir* buffer correctly,
> but vc-diff in the same buffer fails:
>
> Debugger entered--Lisp error: (error "Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py")
> signal(error ("Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py"))
> error("Failed (%s): %s" "status 128" "git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py")
> vc-do-command("*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") "--no-pager" "diff-index" "--exit-code" "-p" "HEAD" nil "--")
> apply(vc-do-command "*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") ("--no-pager" "diff-index" "--exit-code" "-p" "HEAD" nil "--"))
> vc-git-command("*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" "--exit-code" "-p" "HEAD" nil "--")
> apply(vc-git-command "*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" "--exit-code" ("-p" "HEAD" nil "--"))
> vc-git-diff(("/scp:remote:/path/file.py") nil nil "*vc-diff*" t)
> apply(vc-git-diff (("/scp:remote:/path/file.py") nil nil "*vc-diff*" t))
> vc-call-backend(Git diff ("/scp:remote:/path/file.py") nil nil "*vc-diff*" t)
> vc-diff-internal(t (Git ("/scp:remote:/path/file.py")) nil nil t)
> vc-diff(nil t)
> funcall-interactively(vc-diff nil t)
> call-interactively(vc-diff nil nil)
> command-execute(vc-diff)
>
> Same error on = (vc-diff) in the *vc-dir* buffer.
>
> I am pretty sure this is a regression from about 2-3 weeks ago.
>
> (vc-next-action also fails)
This is the result of the git literal pathspec prefix being added in a
non-tramp-aware way. See bug #39452. The commits in question are
3502321403 Fix regressions in the last change
3572613550 Fix vc-git-state for filenames with wildcards
--
Ola Nilsson
next prev parent reply other threads:[~2021-08-25 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 22:09 bug#50175: 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x = (vc-doff) Steingold
2021-08-25 13:26 ` Ola x Nilsson [this message]
2021-08-25 15:45 ` Steingold
2021-08-26 1:51 ` Dmitry Gutov
2021-08-26 6:14 ` Ola x Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwqbl5l1wqd.fsf@axis.com \
--to=ola.x.nilsson@axis.com \
--cc=50175@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=larsi@gnus.org \
--cc=sds@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).