From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ola x Nilsson Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Mon, 28 Aug 2023 11:33:09 +0200 Organization: Axis Communications AB Message-ID: References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87h6oo2may.fsf@gmx.net> <65eb4677-5ae3-5170-1b37-2e02f974c972@gmail.com> <871qfqiygn.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24933"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.14; emacs 30.0.50 Cc: Mauro Aranda , 64046@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 28 11:41:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qaYkZ-0006IE-VX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Aug 2023 11:41:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qaYkF-0005to-25; Mon, 28 Aug 2023 05:41:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaYjw-0005ri-G9 for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 05:40:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qaYjv-0001UO-Sg for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 05:40:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qaYk2-0004hx-42 for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 05:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ola x Nilsson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Aug 2023 09:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169321560818008 (code B ref 64046); Mon, 28 Aug 2023 09:41:02 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 28 Aug 2023 09:40:08 +0000 Original-Received: from localhost ([127.0.0.1]:47009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaYj9-0004gO-La for submit@debbugs.gnu.org; Mon, 28 Aug 2023 05:40:08 -0400 Original-Received: from smtp2.axis.com ([195.60.68.18]:12855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaYj7-0004fo-Ae for 64046@debbugs.gnu.org; Mon, 28 Aug 2023 05:40:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1693215599; x=1724751599; h=references:from:to:cc:subject:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=aAPsTF87Q6jO++E78DU2bmyHts9S//QVpCZ3wFolfi8=; b=H5PXAK1hDrV8d4xBtRquXFo66rszpiBTnD8F8Dz8/0q6rOpG9gNsxKej TbrFvgB22jqxRJDJ6ilLAk39KYaA24dN32tHOODFWjeKM8NQl5sThjtTr OyfmVs6KFb7t15pPwcNJngAO3eMRBHer0JPADZ6P18M+g5UDLgXB5zPrs cT2dglmqBm5SjYM4UzKuXM7FClcxaf6qw/Af3h5CogBSQLV/MS6SVn2G1 Nvb5N7lJM1syuE3P460x2+hRx3ik9o6Fp/dOWXsiUnhqsOmAWIWK4odIm yQXd6+kqbZgjGvBgW+79+0vk9tKpCrBuMbSumT//Gge01nmjqo+Az9ZIp w==; In-Reply-To: <871qfqiygn.fsf@gmx.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268611 Archived-At: On Fri, Aug 25 2023, Stephen Berman wrote: > On Fri, 25 Aug 2023 10:02:35 +0200 Ola x Nilsson = wrote: > >> On Thu, Aug 24 2023, Mauro Aranda wrote: >> >>> Stephen Berman writes: >>> >>>> On Thu, 24 Aug 2023 17:14:53 -0300 Mauro Aranda >>> wrote: > [...] >>>>> Thinking about it, why do we need to call substitute-command-keys on = the >>>>> VALUE part (i.e., the cdr of the cons cell), in case of simple item >>>>> definitions? >>>>> >>>>> I re-read the bug report, but I didn't find any reference to why that= is >>>>> a need.=C2=A0 Did I miss something? >>>> >>>> Well, the VALUE is displayed on entering a choice.=C2=A0 That is, when= I do >>>> >>>> M-: (widget-choose "Title" '(("Use `a'" . "Use `1'") ("Use `b'" >>> . "Use `2'"))) >>>> >>>> I see curve-quoting in the widget-choose buffer: >>>> >>>>=C2=A0=C2=A0=C2=A0 Available choices: >>>> >>>>=C2=A0=C2=A0=C2=A0 0 =3D Use =E2=80=98a=E2=80=99 >>>>=C2=A0=C2=A0=C2=A0 1 =3D Use =E2=80=98b=E2=80=99 >>>> >>>>=C2=A0=C2=A0=C2=A0 C-g =3D Quit >>>> >>>> and when I enter e.g. `0' at the "Title: " prompt in the minibuffer, it >>>> displays "Use =E2=80=981=E2=80=99", i.e., with curve-quoting.=C2=A0 Bu= t if I omit the call to >>>> substitute-command-keys on the cdr in widget-choose, then typing `0' at >>>> the "Title: " prompt displays "Use `1'", i.e. with grave-quoting.=C2= =A0 But I >>>> don't know which one is the intended result. >>> >>> I see, thank you.=C2=A0 Your last patch looks good to me, then. >> >> The cdr is the return value, I would expect widget-choose to not >> modify that.=20 > > I think this is indeed the correct expectation and I should have > recognized it instead of looking only at appearances. But do you agree > that applying (at least) quote substitution to the car of the simple > item definition is appropriate here? If so, there is still the question > of whether to use substitute-command-keys or just substitute-quotes. > I'm inclined to stick with the former but would be fine with going with > the latter. I agree that quote substition should be done on the car of simple item definitions. I have no opinion on susbstitute-command-keys vs substitute-quotes. But I came to think about the TITLE argument, shouldn't quote substition be performed on it as well? /Ola