From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional Date: Fri, 06 May 2016 11:42:39 -0400 Message-ID: References: <572C3010.6080604@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462549481 17749 80.91.229.3 (6 May 2016 15:44:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 May 2016 15:44:41 +0000 (UTC) Cc: 22465@debbugs.gnu.org, Joakim Verona To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 06 17:44:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ayhvZ-0000Tn-Q0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 May 2016 17:44:29 +0200 Original-Received: from localhost ([::1]:58863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayhvW-0003e7-4M for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 May 2016 11:44:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayhvN-0003RX-FL for bug-gnu-emacs@gnu.org; Fri, 06 May 2016 11:44:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayhvB-0002u1-PN for bug-gnu-emacs@gnu.org; Fri, 06 May 2016 11:44:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayhvB-0002tS-Lz for bug-gnu-emacs@gnu.org; Fri, 06 May 2016 11:44:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ayhv8-0003Zp-9q for bug-gnu-emacs@gnu.org; Fri, 06 May 2016 11:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 May 2016 15:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22465-submit@debbugs.gnu.org id=B22465.146254939613667 (code B ref 22465); Fri, 06 May 2016 15:44:02 +0000 Original-Received: (at 22465) by debbugs.gnu.org; 6 May 2016 15:43:16 +0000 Original-Received: from localhost ([127.0.0.1]:41936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayhuO-0003YN-1i for submit@debbugs.gnu.org; Fri, 06 May 2016 11:43:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayhuL-0003YA-Td for 22465@debbugs.gnu.org; Fri, 06 May 2016 11:43:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayhu7-0002dW-Fo for 22465@debbugs.gnu.org; Fri, 06 May 2016 11:43:05 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayhtv-0002Yy-6W; Fri, 06 May 2016 11:42:47 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ayhtn-0002BC-RF; Fri, 06 May 2016 11:42:40 -0400 X-Spook: Gangs 2600 Magazine sweep Centro Foot and Mouth pink X-Ran: qPbZ:=8`|(vc9Ow|$/_#OmX}S X-Hue: yellow X-Attribution: GM In-Reply-To: <572C3010.6080604@cs.ucla.edu> (Paul Eggert's message of "Thu, 5 May 2016 22:48:00 -0700") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117910 Archived-At: Paul Eggert wrote: > Attached is a proposed patch for this bug. It is not fancy, but it > works for me. Thanks. I wonder if the 'image scrolling method should simply be removed, since it doesn't work (to date) and isn't the default. Are two methods really needed/useful? > From 879895ad058294eb49d8372ef5dbf053973e45b9 Mon Sep 17 00:00:00 2001 > From: Paul Eggert > Date: Thu, 5 May 2016 22:44:16 -0700 > Subject: [PATCH] Fix xwidget-webkit-scroll-forward infloop > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > * lisp/xwidget.el (xwidget-webkit-scroll-forward) > (xwidget-webkit-scroll-backward): Don't loop if > xwidget-webkit-scroll-behavior's value is 'image' (Bug#22465). > --- > lisp/xwidget.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lisp/xwidget.el b/lisp/xwidget.el > index 19f631f..d64237a 100644 > --- a/lisp/xwidget.el > +++ b/lisp/xwidget.el > @@ -165,7 +165,7 @@ xwidget-webkit-scroll-forward > (interactive) > (if (eq xwidget-webkit-scroll-behavior 'native) > (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50) > - (xwidget-webkit-scroll-forward))) ; FIXME infloop! > + (image-forward-hscroll 5))) > > (defun xwidget-webkit-scroll-backward () > "Scroll webkit backwards. > @@ -174,7 +174,7 @@ xwidget-webkit-scroll-backward > (interactive) > (if (eq xwidget-webkit-scroll-behavior 'native) > (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50) > - (xwidget-webkit-scroll-backward))) ; FIXME infloop! > + (image-backward-hscroll 5))) > > > ;; The xwidget event needs to go into a higher level handler