From: Glenn Morris <rgm@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: phst@google.com, p.stephani2@gmail.com, 30106@debbugs.gnu.org
Subject: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106)
Date: Thu, 18 Jan 2018 17:55:22 -0500 [thread overview]
Message-ID: <jtk1werd45.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83efmnuhgo.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Jan 2018 20:53:11 +0200")
Eli Zaretskii wrote:
>> If it's not to be fixed then IMO in the meantime configure should
>> explicitly reject --with-modules if threads are disabled.
>
> That'd replace one non-trivial change with another, so I think it's
> worse than fixing the problem.
You think the following is non-trivial?
--- a/configure.ac
+++ b/configure.ac
@@ -3513,6 +3513,8 @@ case $opsys in
*) MODULES_SUFFIX=".so" ;;
esac
if test "${with_modules}" != "no"; then
+ test "${threads_enabled}" = "no" && \
+ AC_MSG_ERROR([modules currently require threads])
case $opsys in
gnu|gnu-linux)
LIBMODULES="-ldl"
next prev parent reply other threads:[~2018-01-18 22:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 6:36 bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Jean Louis
2018-01-14 16:08 ` Eli Zaretskii
2018-01-14 17:47 ` Jean Louis
2018-01-14 19:44 ` Eli Zaretskii
2018-01-14 22:12 ` Jean Louis
2018-01-15 13:14 ` Eli Zaretskii
2018-01-15 17:56 ` Glenn Morris
2018-01-18 19:35 ` Philipp Stephani
2018-01-18 23:00 ` Glenn Morris
2018-01-15 18:09 ` Jean Louis
2018-01-15 18:55 ` Jean Louis
2018-01-15 20:15 ` Eli Zaretskii
2018-01-16 5:17 ` Jean Louis
2018-01-16 18:06 ` Glenn Morris
2018-01-16 19:17 ` Jean Louis
2018-01-16 18:10 ` Eli Zaretskii
2018-01-16 19:18 ` Jean Louis
2018-01-17 15:36 ` Eli Zaretskii
2018-01-17 17:03 ` Jean Louis
2018-01-17 18:25 ` Eli Zaretskii
2018-01-17 18:51 ` Glenn Morris
2018-01-17 18:58 ` Glenn Morris
2018-01-17 19:37 ` Jean Louis
2018-01-18 23:01 ` Glenn Morris
2018-01-17 20:05 ` Eli Zaretskii
2018-01-17 20:29 ` Glenn Morris
2018-01-17 22:16 ` Philipp Stephani
2018-01-17 22:18 ` Philipp Stephani
2018-01-17 22:28 ` bug#30106: [PATCH 1/2] Use recommended long options syntax in man page Philipp Stephani
2018-01-17 22:28 ` bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) Philipp Stephani
2018-01-18 14:04 ` Eli Zaretskii
2018-01-18 14:23 ` Philipp Stephani
2018-01-18 15:23 ` Eli Zaretskii
2018-01-18 17:41 ` Glenn Morris
2018-01-18 18:53 ` Eli Zaretskii
2018-01-18 22:55 ` Glenn Morris [this message]
2018-01-19 7:58 ` Eli Zaretskii
2018-01-20 18:07 ` Glenn Morris
2018-01-20 19:01 ` Eli Zaretskii
2018-01-18 19:25 ` Philipp Stephani
2018-01-17 22:35 ` bug#30106: [PATCH 1/2] Use recommended long options syntax in man page Philipp Stephani
2018-01-18 13:59 ` bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test' Eli Zaretskii
2018-01-18 17:40 ` Glenn Morris
2018-01-17 19:20 ` Jean Louis
2018-01-17 18:32 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jtk1werd45.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=30106@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).