bug#18309: 24.3.93; cua-rectangle-mark-mode error

bug#18309: 24.3.93; cua-rectangle-mark-mode error

[João Távora]

Hi, maintainers,

emacs -Q

In the *scratch* buffer

   M-x beginning-of-buffer
   M-x newline
   M-x forward-word
   M-x cua-rectangle-mark-mode
   M-x cua-resize-rectangle-left
   M-x cua-resize-rectangle-up

An error is signalled

   Error in post-command-hook (cua--rectangle-post-command):
   (args-out-of-range 0 0)

The rectangle is left in an unconsistent state: typing still enters text
inside the rectangle but the red highlighting is never
revived.

Furthermore cursor can be moved to other places and text still goes
inside the rectangle and creating a rectangle somewhere in the same
buffer else somehow revives the old rectangle.

There used to be another bug that I can't reproduce anymore so perhaps
the bug above was introduced by a a fix between 24.3.91 and 24.3.93: An
error used to be signalled sometimes after existing
cua-rectangle-mark-mode and trying to reenter it again in another
location.

Thanks,
João

In GNU Emacs 24.3.93.1 (i686-pc-mingw32)
 of 2014-08-15 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'

Important settings:
  value of $LC_CTYPE: UTF-8
  value of $LANG: C.UTF-8
  locale-coding-system: cp1252

Major mode: Lisp Interaction

bug#18309: 24.3.93; cua-rectangle-mark-mode error

[Glenn Morris]

João Távora wrote:

> In the *scratch* buffer
>
>    M-x beginning-of-buffer
>    M-x newline
>    M-x forward-word
>    M-x cua-rectangle-mark-mode
>    M-x cua-resize-rectangle-left
>    M-x cua-resize-rectangle-up
>
> An error is signalled
>
>    Error in post-command-hook (cua--rectangle-post-command):
>    (args-out-of-range 0 0)

This seems to avoid the error, but I never use this stuff...

*** lisp/emulation/cua-rect.el	2014-07-06 23:58:52 +0000
--- lisp/emulation/cua-rect.el	2014-08-21 20:44:23 +0000
***************
*** 794,800 ****
  			       (make-string
  				(- l cl0 (if (and (= le pl) (/= le lb)) 1 0))
  				(if cua--virtual-edges-debug ?. ?\s))
! 			       'face (or (get-text-property (1- s) 'face) 'default)))
  		     (if (/= pl le)
  			 (setq s (1- s))))
  		   (cond
--- 794,800 ----
  			       (make-string
  				(- l cl0 (if (and (= le pl) (/= le lb)) 1 0))
  				(if cua--virtual-edges-debug ?. ?\s))
! 			       'face (or (get-text-property (max (1- s) (point-min)) 'face) 'default)))
  		     (if (/= pl le)
  			 (setq s (1- s))))
  		   (cond

bug#18309: 24.3.93; cua-rectangle-mark-mode error

[Glenn Morris]

Version: 24.3.94

Installed in the absence of any comments.

Glenn Morris wrote:

> *** lisp/emulation/cua-rect.el	2014-07-06 23:58:52 +0000
> --- lisp/emulation/cua-rect.el	2014-08-21 20:44:23 +0000
> ***************
> *** 794,800 ****
>   			       (make-string
>   				(- l cl0 (if (and (= le pl) (/= le lb)) 1 0))
>   				(if cua--virtual-edges-debug ?. ?\s))
> ! 			       'face (or (get-text-property (1- s) 'face) 'default)))
>   		     (if (/= pl le)
>   			 (setq s (1- s))))
>   		   (cond
> --- 794,800 ----
>   			       (make-string
>   				(- l cl0 (if (and (= le pl) (/= le lb)) 1 0))
>   				(if cua--virtual-edges-debug ?. ?\s))
> ! 			       'face (or (get-text-property (max (1- s) (point-min)) 'face) 'default)))
>   		     (if (/= pl le)
>   			 (setq s (1- s))))
>   		   (cond

bug#18309: closed (Re: bug#18309: 24.3.93; cua-rectangle-mark-mode error)

[João Távora]

> From: Glenn Morris <rgm@gnu.org>
>
> Installed in the absence of any comments.

I meant to report that it works nicely now, but I forgot

Thanks,
João