From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f Date: Mon, 14 Jan 2019 17:11:58 +0000 Message-ID: References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1547485873 7407 195.159.176.226 (14 Jan 2019 17:11:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Jan 2019 17:11:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) Cc: 34070@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 14 18:11:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj5lU-0001lW-8X for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Jan 2019 18:11:08 +0100 Original-Received: from localhost ([127.0.0.1]:49453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj5nb-0007rw-2R for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Jan 2019 12:13:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj5nN-0007pj-S6 for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 12:13:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj5nL-00022b-W8 for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 12:13:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59998) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gj5nK-00022L-HL for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 12:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gj5nK-000123-9N for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 12:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Jan 2019 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34070 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 34070-submit@debbugs.gnu.org id=B34070.15474859343912 (code B ref 34070); Mon, 14 Jan 2019 17:13:02 +0000 Original-Received: (at 34070) by debbugs.gnu.org; 14 Jan 2019 17:12:14 +0000 Original-Received: from localhost ([127.0.0.1]:59279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj5mY-000112-34 for submit@debbugs.gnu.org; Mon, 14 Jan 2019 12:12:14 -0500 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:51539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj5mU-00010n-9k for 34070@debbugs.gnu.org; Mon, 14 Jan 2019 12:12:12 -0500 Original-Received: by mail-wm1-f48.google.com with SMTP id b11so353437wmj.1 for <34070@debbugs.gnu.org>; Mon, 14 Jan 2019 09:12:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=61IS+JHVGiIamP2ooK6dikoo36ljAlP0/s3dmUPsUME=; b=pPNgYKSwc1H4/M4XivIUI1CQxQFrT6iSgtudQZAOieAmMJ7K6sOVfcHA/FvnjyShxV d82OdO/WwwvTwPRXNqScIOCD+h8lG/eimQontOIgvj7MBHzmfZ4fb7L2qehQK5Gjmyj1 GO03U3z+by74lmEEUT3tGor0fjtucdG81ypwOLeLZ4huH0yxCIu5/8ztMq7LxwWU/1IA bEA/fltMErjWQB+3pzkFuuouHr2OeXILGTa635IOE65p1I29LtBwSsh/XR4601AHP9Oe eMlKn6e40KsQ58+sqoXlR1HTnHVGv36S9G2upHIUpOUDbGsmnx3IaPaQx80Jlo2Z7yeE mxQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=61IS+JHVGiIamP2ooK6dikoo36ljAlP0/s3dmUPsUME=; b=F+6u4pV/omXcYPm6o4Zc9NLeFkgTXghbknKxSwlWUiW6GsKAzE1/js5MdiFTDcx/wS M6/wQYYYHsTSbPu3YthIVKaZdl/ijxO5WPvIrKnMyjMVJ4bfpPdELVnKM4rb+I96SFal MVxjsoIZWHMG+i2Q+1MzzH1OFqGsxxGXiqn+8EhkIfqikzfJWLw2bzqA2d9wtPdgxdng JzF0nHnJuT2ABsQ7DkMJcdyW89dCaGEL4W8ENIIi70ZofqEknLIEHnOEG4cAy/c7GiXW aRRmFt3wasJwFuwgWMy5MmQxMTYeBdhqnTii0gZ+ERix7wBrK9HEkEI/g2lyoYfvbWkD l6AQ== X-Gm-Message-State: AJcUukcMBcrpVaRcclb9sQjO6X4TnqdEHmYGKDYm+ZQVRCI1m/T4xbeY J5WOpLQL2AjyO0Rz46mDxsc= X-Google-Smtp-Source: ALg8bN7MTCKrzfIp1xJqAa813rmR7T7AqLObrLtJZB3ze49aqBeyvRhJL0Vouf657P17XvoxrUZ7/Q== X-Received: by 2002:a7b:cc86:: with SMTP id p6mr96444wma.19.1547485924375; Mon, 14 Jan 2019 09:12:04 -0800 (PST) Original-Received: from GONDOMAR.yourcompany.com (mail3.siscog.pt. [195.23.29.18]) by smtp.gmail.com with ESMTPSA id t76sm31654845wme.33.2019.01.14.09.12.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 09:12:03 -0800 (PST) In-Reply-To: <83d0ozdwfz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Jan 2019 18:40:32 +0200") X-Antivirus: AVG (VPS 190114-0, 14-01-2019), Outbound message X-Antivirus-Status: Clean X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154438 Archived-At: Eli Zaretskii writes: >> From: Jo=E3o T=E1vora >> Cc: Drew Adams , 34070@debbugs.gnu.org, monnier= @iro.umontreal.ca >> Date: Mon, 14 Jan 2019 16:25:41 +0000 >>=20 >> > Please add a test for this, if possible, so that we don't screw this >> > up again in the future. >>=20 >> I'd love to, but it's not exactly simple to write tests that observe >> user interaction the minibuffer with ert. At least for me. How would I >> go about doing that? Any pointers/prior art? > > (A stab in the dark) invoke the function bound to TAB and examine what > it produces? :-) Where do you mean TAB? It's not even in the recipe. Well I though about it a bit and can probalby use minibuffer-setup-hook (let ((minibuffer-setup-hook (append minibuffer-setup-hook (list (lambda () ;; commands and observations )))) (default-directory source-directory)) (find-file-read-args "Find file: " (confirm-nonexistent-file-or-buffer))) Don't know how to observe the icomplete candidates though, but this strategy is probably enough to make a test. I'd like to push the fix before that maybe, any objections? Jo=E3o