From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: Re: huge files in ~/.emacs.d/auto-save-list/ Date: Wed, 23 May 2007 11:32:10 +0200 Message-ID: References: <17763.1179779953@gemini.franz.com> <20566.1179846367@gemini.franz.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1179912756 4161 80.91.229.12 (23 May 2007 09:32:36 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 23 May 2007 09:32:36 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 23 11:32:33 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HqnCm-0006cZ-M1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2007 11:32:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HqnCn-0007bX-Fi for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2007 05:32:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HqnCc-0007a5-M5 for bug-gnu-emacs@gnu.org; Wed, 23 May 2007 05:32:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HqnCZ-0007ZT-R4 for bug-gnu-emacs@gnu.org; Wed, 23 May 2007 05:32:16 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HqnCZ-0007ZQ-Hk for bug-gnu-emacs@gnu.org; Wed, 23 May 2007 05:32:15 -0400 Original-Received: from ns.suse.de ([195.135.220.2] helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HqnCY-0006wr-78; Wed, 23 May 2007 05:32:14 -0400 Original-Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 9CBCC122E3; Wed, 23 May 2007 11:32:11 +0200 (CEST) X-Yow: I would like to urinate in an OVULAR, porcelain pool -- In-Reply-To: (Richard Stallman's message of "Tue\, 22 May 2007 19\:10\:08 -0400") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.97 (gnu/linux) X-detected-kernel: Linux 2.4-2.6 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:15738 Archived-At: Richard Stallman writes: > The existing code relies on an unwind-protect to close the stream. > Maybe something fails to run the unwind-protect. Could you try > running with this change, and tell us if it prevents the problem? > > > > *** fileio.c 22 Mar 2007 08:15:04 -0400 1.580 > --- fileio.c 22 May 2007 14:23:20 -0400=09 > *************** > *** 6021,6026 **** > --- 6021,6027 ---- > =20 > /* Prevent another auto save till enough input events come in. */ > record_auto_save (); > + fclose (stream); This will cause crashes. First, stream may be NULL, second, using stream after fclose is undefined. Andreas. --=20 Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."