unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: rms@gnu.org
Cc: bug-gnu-emacs@gnu.org
Subject: Re: huge files in ~/.emacs.d/auto-save-list/
Date: Wed, 23 May 2007 11:32:10 +0200	[thread overview]
Message-ID: <jetzu3ans5.fsf@sykes.suse.de> (raw)
In-Reply-To: <E1HqdUW-0001rg-Ae@fencepost.gnu.org> (Richard Stallman's message of "Tue\, 22 May 2007 19\:10\:08 -0400")

Richard Stallman <rms@gnu.org> writes:

> The existing code relies on an unwind-protect to close the stream.
> Maybe something fails to run the unwind-protect.  Could you try
> running with this change, and tell us if it prevents the problem?
>
>
>
> *** fileio.c	22 Mar 2007 08:15:04 -0400	1.580
> --- fileio.c	22 May 2007 14:23:20 -0400	
> ***************
> *** 6021,6026 ****
> --- 6021,6027 ----
>   
>     /* Prevent another auto save till enough input events come in.  */
>     record_auto_save ();
> +   fclose (stream);

This will cause crashes.  First, stream may be NULL, second, using
stream after fclose is undefined.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  parent reply	other threads:[~2007-05-23  9:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21 20:39 huge files in ~/.emacs.d/auto-save-list/ Kevin Layer
2007-05-21 20:55 ` Eli Zaretskii
2007-05-21 21:47   ` Kevin Layer
2007-05-22 14:52 ` Richard Stallman
2007-05-22 15:06   ` Kevin Layer
2007-05-22 23:10     ` Richard Stallman
2007-05-22 23:26       ` Kevin Layer
2007-05-23 18:56         ` Richard Stallman
2007-05-23 19:33           ` Kevin Layer
2007-05-24 10:55             ` Richard Stallman
2007-05-24 14:43               ` Kevin Layer
2007-05-26  0:19                 ` Richard Stallman
2007-05-23 19:42           ` Kevin Layer
2007-05-23  9:32       ` Andreas Schwab [this message]
2007-05-23 11:47         ` Eli Zaretskii
2007-05-23 23:45           ` Richard Stallman
2007-05-23 18:56         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jetzu3ans5.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).