find-file-read-only-other-frame broken

find-file-read-only-other-frame broken

[Jörg-Volker Peetz]

Dear Emacs-developers,

since version 22 the function 'find-file-read-only-other-frame' does
*not switch to read-only mode* indicated by the two percent-signs in
the status line and the contents of the new buffer can be changed.

Regards,
Jörg-Volker Peetz.

P.S.: Last but not least, thank you very much for your fine work. I'm
      using emacs since version 18 and enjoy it very much.


In GNU Emacs 22.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2007-12-15 on noname, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.10400000
configured using `configure  '--build=i486-linux-gnu'
'--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib'
'--libexecdir=/usr/lib' '--localstatedir=/var/lib'
'--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes'
'--enable-locallisppath=/etc/emacs22:/etc/emacs:/usr/local/share/emacs/22.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/22.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/22.1/leim'
'--with-x=yes' '--with-x-toolkit=athena' '--with-toolkit-scroll-bars'
'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu'
'CFLAGS=-DDEBIAN -g -O2''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  display-time-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
<help-echo> <escape> x r e p o r t - e m <tab> <re
turn>

Recent messages:
Loading /etc/emacs/site-start.d/50octave2.9-emacsen.el (source)...done
Loading /etc/emacs22/site-start.d/50psgml-init.el (source)...done
Loading /etc/emacs/site-start.d/50psvn.el (source)...done
Loading /etc/emacs/site-start.d/51debian-el.el (source)...done
Toggling tool-bar-mode off; better pass an explicit argument.
Loading time...done
For information about the GNU Project and its goals, type C-h C-p. [2 times]
Loading emacsbug...
Loading regexp-opt...done
Loading emacsbug...done

Re: find-file-read-only-other-frame broken

[Sven Joachim]

On 2007-12-23 10:44 +0100, Jörg-Volker Peetz wrote:

> since version 22 the function 'find-file-read-only-other-frame' does
> *not switch to read-only mode* indicated by the two percent-signs in
> the status line and the contents of the new buffer can be changed.

Can you please try the following patch, which should fix the issue?

--8<---------------cut here---------------start------------->8---
--- files.el	23 Dez 2007 15:07:56 +0100	1.896.2.32
+++ files.el	23 Dez 2007 15:24:27 +0100	
@@ -1015,9 +1015,11 @@
 documentation for additional customization information."
   (interactive "BSwitch to buffer in other frame: ")
   (let ((pop-up-frames t)
+	ret
 	same-window-buffer-names same-window-regexps)
-    (pop-to-buffer buffer t norecord)
-    (raise-frame (window-frame (selected-window)))))
+    (setq ret (pop-to-buffer buffer t norecord)) ; save return value
+    (raise-frame (window-frame (selected-window)))
+    ret))
 
 (defun display-buffer-other-frame (buffer)
   "Switch to buffer BUFFER in another frame.
--8<---------------cut here---------------end--------------->8---

In case somebody wants to install it into EMACS_22_BASE, here's a
ChangeLog entry as well:

2007-12-23  Sven Joachim <svenjoac@gmx.de>

	* files.el (switch-to-buffer-other-frame): Return the buffer, not
	nil.

Cheers,
       Sven

Re: find-file-read-only-other-frame broken

[Thien-Thi Nguyen]

() Sven Joachim <svenjoac@gmx.de>
() Sun, 23 Dec 2007 16:31:35 +0100

   +    (setq ret (pop-to-buffer buffer t norecord)) ; save return value
   +    (raise-frame (window-frame (selected-window)))
   +    ret))

you can use `prog1' for this.

thi

Re: find-file-read-only-other-frame broken

[Andreas Schwab]

Jörg-Volker Peetz <peetz@dynato-kyma.net> writes:

> since version 22 the function 'find-file-read-only-other-frame' does
> *not switch to read-only mode* indicated by the two percent-signs in
> the status line and the contents of the new buffer can be changed.

Thanks for the report, this will be fixed in the next release.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: find-file-read-only-other-frame broken

[Sven Joachim]

On 2007-12-23 17:01 +0100, Thien-Thi Nguyen wrote:

> () Sven Joachim <svenjoac@gmx.de>
> () Sun, 23 Dec 2007 16:31:35 +0100
>
>    +    (setq ret (pop-to-buffer buffer t norecord)) ; save return value
>    +    (raise-frame (window-frame (selected-window)))
>    +    ret))
>
> you can use `prog1' for this.

Thanks.  Despite searching for one hour in the Emacs Lisp Manual, I had
not found prog1. :-/  One day I shall read the manual in its entirety.

Sven

Re: find-file-read-only-other-frame broken

[Thien-Thi Nguyen]

() Sven Joachim <svenjoac@gmx.de>
() Sun, 23 Dec 2007 17:53:45 +0100

   One day I shall read the manual in its entirety.

that's one way to pass the while.

probably more fun/useful is reading good code, assuming
what is good and what is not good can be identified.

thi