bug#5113: handle shell escape characters (e.g. ESC [ 0) in emacs shell

bug#5113: handle shell escape characters (e.g. ESC [ 0) in emacs shell

[Praveen A]

Hi,
It seems that when 'ls' is invoked with --color, it output
some escape sequences (e.g. ESC [ 0) that are not handled by
shell-mode."
Ref http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=5080#80 point 2

It would be good if emacs shell can handle these escape characters --
even if color is not displayed, the escape characters should be
hidden.

Regards
Praveen
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign

bug#5113: handle shell escape characters (e.g. ESC [ 0) in emacs shell

[Glenn Morris]

Praveen A wrote:

> It seems that when 'ls' is invoked with --color, it output some
> escape sequences (e.g. ESC [ 0) that are not handled by shell-mode.

The Emacs manual and FAQ suggest

   (add-hook 'shell-mode-hook 'ansi-color-for-comint-mode-on)

bug#5113: handle shell escape characters (e.g. ESC [ 0) in emacs shell

[Stefan Monnier]

>> It seems that when 'ls' is invoked with --color, it output some
>> escape sequences (e.g. ESC [ 0) that are not handled by shell-mode.

> The Emacs manual and FAQ suggest

>    (add-hook 'shell-mode-hook 'ansi-color-for-comint-mode-on)

Any objection to enabling it by default?


        Stefan

bug#5113: marked as done (ansi-color-for-comint-mode-on on by default in shell-mode)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

Your message dated Sat, 05 Dec 2009 16:05:49 -0500
with message-id <87my1x168i.fsf@stupidchicken.com>
and subject line Re: bug#5113: handle shell escape characters (e.g. ESC [ 0) in emacs shell
has caused the Emacs bug report #5113,
regarding ansi-color-for-comint-mode-on on by default in shell-mode
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
5113: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=5113
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3704 bytes --]

From: Praveen A <pravi.a@gmail.com>
To: bug-gnu-emacs@gnu.org
Subject: handle shell escape characters (e.g. ESC [ 0) in emacs shell
Date: Thu, 3 Dec 2009 14:47:12 +0530
Message-ID: <3f2beab60912030117n4005a75w42481261c854c655@mail.gmail.com>

Hi,
It seems that when 'ls' is invoked with --color, it output
some escape sequences (e.g. ESC [ 0) that are not handled by
shell-mode."
Ref http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=5080#80 point 2

It would be good if emacs shell can handle these escape characters --
even if color is not displayed, the escape characters should be
hidden.

Regards
Praveen
-- 
പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
Join The DRM Elimination Crew Now!
http://fci.wikia.com/wiki/Anti-DRM-Campaign



[-- Attachment #3: Type: message/rfc822, Size: 1887 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Glenn Morris <rgm@gnu.org>, 5113-done@emacsbugs.donarmstrong.com, Praveen A <pravi.a@gmail.com>
Subject: Re: bug#5113: handle shell escape characters (e.g. ESC [ 0) in emacs shell
Date: Sat, 05 Dec 2009 16:05:49 -0500
Message-ID: <87my1x168i.fsf@stupidchicken.com>

> >> It seems that when 'ls' is invoked with --color, it output some
> >> escape sequences (e.g. ESC [ 0) that are not handled by shell-mode.
>
> > The Emacs manual and FAQ suggest
>
> >    (add-hook 'shell-mode-hook 'ansi-color-for-comint-mode-on)
>
> Any objection to enabling it by default?

I just enabled it by default in the repository.