From: Gunnar Horrigmo <gnunar@stoffe-pro.net>
To: 46056@debbugs.gnu.org
Subject: bug#46056: hardcoded ~/.emacs.d in elpa package excorporate
Date: Sat, 23 Jan 2021 19:13:44 +0100 [thread overview]
Message-ID: <iv41rebzfl3.fsf@hot-rats.uio.no> (raw)
The `excorporate' package hardcodes its diary files to
~/.emacs.d/excorporate, instead of honoring user-emacs-directory.
I've included a small fix:
=== begin diff ===
diff --git a/excorporate-diary.el b/excorporate-diary.el
index 833df3017c..b147bed42d 100644
--- a/excorporate-diary.el
+++ b/excorporate-diary.el
@@ -76,13 +76,17 @@ respectively."
#'exco-diary-icalendar--add-diary-entry-around))
(defvar excorporate-diary-today-file
- "~/.emacs.d/excorporate/diary-excorporate-today"
+ (concat
+ (file-name-as-directory user-emacs-directory)
+ "excorporate/diary-excorporate-today")
"The diary file where Excorporate should save today's meetings.
This file will be #include'd in `diary-file' by
`excorporate-diary-enable'.")
(defvar excorporate-diary-transient-file
- "~/.emacs.d/excorporate/diary-excorporate-transient"
+ (concat
+ (file-name-as-directory user-emacs-directory)
+ "excorporate/diary-excorporate-transient")
"The diary file where Excorporate should save retrieved meetings.
This file will be #include'd in `diary-file' by
`excorporate-diary-enable'.")
[gunnar@titanium excorporate]$ git diff -u
diff --git a/excorporate-diary.el b/excorporate-diary.el
index 833df3017c..b147bed42d 100644
--- a/excorporate-diary.el
+++ b/excorporate-diary.el
@@ -76,13 +76,17 @@ respectively."
#'exco-diary-icalendar--add-diary-entry-around))
(defvar excorporate-diary-today-file
- "~/.emacs.d/excorporate/diary-excorporate-today"
+ (concat
+ (file-name-as-directory user-emacs-directory)
+ "excorporate/diary-excorporate-today")
"The diary file where Excorporate should save today's meetings.
This file will be #include'd in `diary-file' by
`excorporate-diary-enable'.")
(defvar excorporate-diary-transient-file
- "~/.emacs.d/excorporate/diary-excorporate-transient"
+ (concat
+ (file-name-as-directory user-emacs-directory)
+ "excorporate/diary-excorporate-transient")
"The diary file where Excorporate should save retrieved meetings.
This file will be #include'd in `diary-file' by
`excorporate-diary-enable'.")
=== end diff ===
Am I submitting this the right way?
--
Gunnar
next reply other threads:[~2021-01-23 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 18:13 Gunnar Horrigmo [this message]
2021-01-23 22:31 ` bug#46056: hardcoded ~/.emacs.d in elpa package excorporate Basil L. Contovounesios
2021-01-24 2:45 ` Gunnar Horrigmo
2021-01-24 3:16 ` Thomas Fitzsimmons
2021-01-24 9:21 ` Michael Albinus
2021-01-24 17:34 ` Thomas Fitzsimmons
2021-01-24 17:40 ` Michael Albinus
2021-01-24 12:04 ` Basil L. Contovounesios
2021-01-24 12:48 ` Gunnar Horrigmo
2021-01-24 11:58 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=iv41rebzfl3.fsf@hot-rats.uio.no \
--to=gnunar@stoffe-pro.net \
--cc=46056@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).