smtpmail.el: typo?

smtpmail.el: typo?

[Felix Natter]

hi,

I get this error when sending mail via smtpmail.el 
(from cvs: http://savannah.gnu.org/cgi-bin/viewcvs/emacs/emacs/lisp/mail/smtpmail.el):

Debugger entered--Lisp error: (void-function mail-envelope-from)
  (mail-envelope-from)
  (or (mail-envelope-from) smtpmail-mail-address user-mail-address)
  (let ((process nil) (host ...) (port smtpmail-smtp-service) (envelope-from ...) response-code greeting process-buffer (supported-extensions ...)) (unwind-protect (catch ... ... ... ... ... ... ...) (if process ...)))
  smtpmail-via-smtp(("raymond.niessing@web.de") #<buffer  smtpmail temp>)
  (not (smtpmail-via-smtp smtpmail-recipient-address-list tembuf))
  (if (not (smtpmail-via-smtp smtpmail-recipient-address-list tembuf)) (error "Sending failed; SMTP protocol error"))
  (if (not (null smtpmail-recipient-address-list)) (if (not ...) (error "Sending failed; SMTP protocol error")) (error "Sending failed; no recipients"))
  (if (not smtpmail-queue-mail) (if (not ...) (if ... ...) (error "Sending failed; no recipients")) (let* (... ... ... ... ... ...) (unless ... ...) (with-current-buffer buffer-data ... ... ... ... ... ... ... ... ... ...) (kill-buffer buffer-scratch) (kill-buffer buffer-data) (kill-buffer buffer-elisp)))
  (save-excursion (set-buffer tembuf) (erase-buffer) (insert-buffer-substring mailbuf) (goto-char (point-max)) (or (= ... 10) (insert 10)) (mail-sendmail-undelimit-header) (setq delimline (point-marker)) (if mail-aliases (expand-mail-aliases ... delimline)) (goto-char (point-min)) (while (and ... ...) (replace-match "\n")) (let (...) (goto-char ...) (if ... ... ...) (goto-char ...) (if ... ...) (goto-char ...) (unless ... ...) (goto-char ...) (unless ... ...) (goto-char ...) (if ... ...) (goto-char ...) (if ... ...) (if mail-interactive ...)) (setq smtpmail-address-buffer (generate-new-buffer "*smtp-mail*")) (setq smtpmail-recipient-address-list (smtpmail-deduce-address-list tembuf ... delimline)) (kill-buffer smtpmail-address-buffer) (smtpmail-do-bcc delimline) (if (not smtpmail-queue-mail) (if ... ... ...) (let* ... ... ... ... ... ...)))
  (unwind-protect (save-excursion (set-buffer tembuf) (erase-buffer) (insert-buffer-substring mailbuf) (goto-char ...) (or ... ...) (mail-sendmail-undelimit-header) (setq delimline ...) (if mail-aliases ...) (goto-char ...) (while ... ...) (let ... ... ... ... ... ... ... ... ... ... ... ... ... ...) (setq smtpmail-address-buffer ...) (setq smtpmail-recipient-address-list ...) (kill-buffer smtpmail-address-buffer) (smtpmail-do-bcc delimline) (if ... ... ...)) (kill-buffer tembuf) (if (bufferp errbuf) (kill-buffer errbuf)))
  (let ((errbuf ...) (tembuf ...) (case-fold-search nil) delimline (mailbuf ...) (smtpmail-mail-address user-mail-address) (smtpmail-code-conv-from ...)) (unwind-protect (save-excursion ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ...) (kill-buffer tembuf) (if ... ...)))
  smtpmail-send-it()
  gnus-agent-send-mail()
  message-send-mail(nil)
  message-send-via-mail(nil)
  message-send(nil)
  message-send-and-exit(nil)
  call-interactively(message-send-and-exit)

with this patch it works:
548c548
< 	(envelope-from (or (mail-envelope-from)
---
> 	(envelope-from (or mail-envelope-from

(ok, some people consider it bragging to call this a patch :-)

thanks,

-- 
Felix Natter
Obsessive. C-K. (http://www.gnu.org/software/emacs/)

Re: smtpmail.el: typo?

[Juri Linkov]

Felix Natter <fnatter@gmx.net> writes:
> hi,
> 
> I get this error when sending mail via smtpmail.el 
> (from cvs: http://savannah.gnu.org/cgi-bin/viewcvs/emacs/emacs/lisp/mail/smtpmail.el):
> 
> Debugger entered--Lisp error: (void-function mail-envelope-from)
>
> [skipped...]
> 
> with this patch it works:
> 548c548
> < 	(envelope-from (or (mail-envelope-from)
> ---
> > 	(envelope-from (or mail-envelope-from

No, this is not a typo.  The function `mail-envelope-from' is defined
in lisp/mail/sendmail.el.  It returns the value of variable with same name
`mail-envelope-from' or the contents of the "From" header of the message.

-- 
http://www.jurta.org/emacs/

Re: smtpmail.el: typo?

[Simon Josefsson]

Felix Natter <fnatter@gmx.net> writes:

> hi,
>
> I get this error when sending mail via smtpmail.el 
> (from cvs: http://savannah.gnu.org/cgi-bin/viewcvs/emacs/emacs/lisp/mail/smtpmail.el):

That file requires other files from Emacs CVS, so you can't simply
take one elisp file from CVS and expect it to work with your old elisp
files.  I believe sendmail.el is necessary as well, but there may be
others as well.