From: Simon Josefsson <jas@extundo.com>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: browse-url-galeon incorrect
Date: Wed, 15 May 2002 20:04:20 +0200 [thread overview]
Message-ID: <ilu661pwamz.fsf@latte.josefsson.org> (raw)
In-Reply-To: <E177d4j-00063X-00@lemming.engeast.baynetworks.com> ("Paul Smith"'s message of "Tue, 14 May 2002 10:14:49 -0400")
"Paul Smith"<pausmith@nortelnetworks.com> writes:
> The browse-url.el:browse-url-galeon function is wrong. It constructs
> the arguments to Galeon like this:
>
> (concat "galeon " url) nil
> browse-url-galeon-program
> (append
> browse-url-galeon-arguments
> (if new-window '("-w" "--noraise"))
> (list "-x" url))
>
> This is broken, though. The "-x" argument overrides the setting of the
> new-window flag; "-x" means "Attempt to load URL in existing Galeon
> window", and the last such argument on the command line always takes
> precedence. I think the "-x" should be removed, as I think it's not
> appropriate to have no way of passing _exactly_ the arguments you want,
> and only those.
The current code has been changed into the following. Does it work
better for you?
...
(process (apply 'start-process
(concat "galeon " url) nil
browse-url-galeon-program
(append
browse-url-galeon-arguments
(if (browse-url-maybe-new-window new-window)
(if browse-url-galeon-new-window-is-tab
'("--new-tab")
'("--new-window" "--noraise"))
'("--existing"))
(list url)))))
...
next prev parent reply other threads:[~2002-05-15 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-14 14:14 browse-url-galeon incorrect Paul Smith
2002-05-15 18:04 ` Simon Josefsson [this message]
2002-05-15 18:35 ` Sunil Patel
2002-05-16 16:20 ` Simon Josefsson
2002-05-17 19:44 ` Christopher S. Kush
2002-05-17 19:50 ` Sunil Patel
2002-05-16 20:24 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ilu661pwamz.fsf@latte.josefsson.org \
--to=jas@extundo.com \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).