From: Simon Josefsson <jas@extundo.com>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: [PATCH] browse-url.el mozilla tab support
Date: Thu, 10 Oct 2002 23:59:44 +0200 [thread overview]
Message-ID: <ilu65wakl9r.fsf@latte.josefsson.org> (raw)
In-Reply-To: <microsoft-free.x4wuoq7ykf.fsf@eicq.dnsalias.org> (Steve Youngs's message of "Fri, 11 Oct 2002 07:50:56 +1000")
Steve Youngs <youngs@xemacs.org> writes:
> |--==> "SJ" == Simon Josefsson <jas@extundo.com> writes:
>
> SJ> Steve, have you signed papers for browse-url.el? I wanted to get
> SJ> Emacs to include your XEmacs browse-url.el patch too. Thanks.
> SJ> (Maybe papers aren't required for that patch though..)
>
> Not for browse-url.el specifically, no. Let me know if you need it.
What does the Emacs maintainers think? Are papers necessary for the
following patch, which mimics already existing Galeon code?
--- browse-url.el.~1.23.~ 2002-07-25 20:49:46.000000000 +0200
+++ browse-url.el 2002-10-10 16:34:46.000000000 +0200
@@ -335,6 +335,13 @@
:type '(repeat (string :tag "Argument"))
:group 'browse-url)
+(defcustom browse-url-mozilla-new-window-is-tab nil
+ "*Whether to open up new windows in a tab or a new window.
+If non-nil, then open the URL in a new tab rather than a new window if
+`browse-url-mozilla' is asked to open it in a new window."
+ :type 'boolean
+ :group 'browse-url)
+
(defcustom browse-url-galeon-new-window-is-tab nil
"*Whether to open up new windows in a tab or a new window.
If non-nil, then open the URL in a new tab rather than a new window if
@@ -862,7 +873,8 @@
(setq url (replace-match
(format "%%%x" (string-to-char (match-string 0 url))) t t url)))
(let* ((process-environment (browse-url-process-environment))
- (process (apply 'start-process
+ (process
+ (apply 'start-process
(concat "mozilla " url) nil
browse-url-mozilla-program
(append
@@ -870,7 +882,11 @@
(list "-remote"
(concat "openURL("
url
- (if new-window ",new-window")
+ (if (browse-url-maybe-new-window
+ new-window)
+ (if browse-url-mozilla-new-window-is-tab
+ ",new-tab")
+ ",new-window")
")"))))))
(set-process-sentinel process
`(lambda (process change)
prev parent reply other threads:[~2002-10-10 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-10 14:37 [PATCH] browse-url.el mozilla tab support Simon Josefsson
[not found] ` <jas@extundo.com>
2002-10-10 17:31 ` Peter S Galbraith
2002-10-10 17:40 ` Simon Josefsson
2002-10-10 21:50 ` Steve Youngs
2002-10-10 21:59 ` Simon Josefsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ilu65wakl9r.fsf@latte.josefsson.org \
--to=jas@extundo.com \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).