From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#63539: 29.0.90; TRAMP fails to detect shell prompts containing ] Date: Wed, 17 May 2023 10:59:52 -0400 Message-ID: References: <877ct8w4bs.fsf@gmx.de> <87sfbvuk4r.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33587"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63539@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 17 17:00:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzIdV-0008Tt-U8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 May 2023 17:00:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzIdJ-0002QI-Kw; Wed, 17 May 2023 11:00:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzIdH-0002Pp-46 for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 11:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzIdG-0003mp-NQ for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 11:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzIdG-0006Or-FL for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 11:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 May 2023 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63539 X-GNU-PR-Package: emacs Original-Received: via spool by 63539-submit@debbugs.gnu.org id=B63539.168433560124563 (code B ref 63539); Wed, 17 May 2023 15:00:02 +0000 Original-Received: (at 63539) by debbugs.gnu.org; 17 May 2023 15:00:01 +0000 Original-Received: from localhost ([127.0.0.1]:50639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzIdE-0006O7-QW for submit@debbugs.gnu.org; Wed, 17 May 2023 11:00:01 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:45597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzIdC-0006Ns-Df for 63539@debbugs.gnu.org; Wed, 17 May 2023 10:59:58 -0400 In-Reply-To: <87sfbvuk4r.fsf@gmx.de> (Michael Albinus's message of "Wed, 17 May 2023 16:07:16 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261865 Archived-At: Michael Albinus writes: > Spencer Baugh writes: >> But such machines' prompts stop working if they add color, which >> shell-prompt-pattern also doesn't support (namely that regex doesn't >> support escape sequences appearing after the prompt, which are necessary >> to clear the coloring). >> >> So actually, how about setting shell-prompt-pattern to the following? >> All it does is add support for escape characters after the prompt in >> shell-prompt-pattern. That would make my use case work. >> >> (setopt shell-prompt-pattern (rx (* (not (any "#$%>\n"))) >> (any "#$%>") >> (* blank) >> ;; Escape characters. >> (* "^[[" (* (any ";" digit)) alpha (* blank)))) > > Oh no! There are much more escape sequences but for coloring. We would > open a can of worms if we start to handle them in Tramp regexps. Wait, but we already have exactly this kind of regexp for escape characters in tramp-shell-prompt-regexp. That's where I copied this regexp from.