From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74792: 29.2.50; goto-address-mode should support RET in special-mode buffers Date: Wed, 11 Dec 2024 11:10:53 -0500 Message-ID: Reply-To: Spencer Baugh Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1694"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev To: 74792@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 11 17:12:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLPK2-0000HM-2G for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Dec 2024 17:12:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLPJl-0006vs-6C; Wed, 11 Dec 2024 11:12:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLPJi-0006vW-H1 for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 11:12:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLPJi-00069K-7y for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 11:12:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=PBDwK6awLFEZUM25hGwHR51GMbuAJh4nrd8U8iA3Vro=; b=NfzhmUMsEYlGPtgyyvZojLzdbgONYmEAnJFVjtDrPefeCmruTFT46MgmlV1nn8kVYPf6hkwV2N1L4r3HlRfsP//j4thdIsle9M5zuYc4MegVgIwp5BuSzU3Qg0Nnk82xcD9f6rW9LmejLQyxJVjFiHsH0JKs0I8bM9f1BPqAkNq2bx++2X8KnxwPRisBe1agGZC1QayJGSAhA0DPiY+1MB53u35JcpBK041gXRKKFLuzZjXg1QxMzfXx8lCrKEh/UskQm4PPTTN8XcJvbd5HkrHS8QFs8tmBI51BjbSYo5H7oS5254Vmjsk2WcP3HOcJH7KAjpvPgfxRVlNz8nvB8g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLPJi-0001sl-2C for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 11:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2024 16:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74792 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17339334676846 (code B ref -1); Wed, 11 Dec 2024 16:12:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Dec 2024 16:11:07 +0000 Original-Received: from localhost ([127.0.0.1]:35845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLPIp-0001mJ-3V for submit@debbugs.gnu.org; Wed, 11 Dec 2024 11:11:07 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:54060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLPIl-0001lr-NI for submit@debbugs.gnu.org; Wed, 11 Dec 2024 11:11:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLPIf-000618-4F for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 11:10:58 -0500 Original-Received: from mxout6.mail.janestreet.com ([64.215.233.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLPIc-00062U-Ug for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 11:10:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1733933453; bh=PBDwK6awLFEZUM25hGwHR51GMbuAJh4nrd8U8iA3Vro=; h=From:To:Cc:Subject:Date; b=l0JU5Pn0MbZgB1sWkNCorGejJ5T2x90OeJF/n1evTnIP8Kgmf/b3sWRR4PSo7lfSp INFafV20qn+lECPVLeG0wIDb70Em8mugHeiOFBZyqNNoPy5FW4j/uVVAtnQiotpYO6 XrMA3ktbioKJEvzhCodEFWOl33GuI0Y41wjSxZxFRU1BXHKafHOzmgB0zcBE7BFREN fB31IesliQq8Lw2T7JltoDQ+tG/UVVQqBGyuztbOud8pLpVHiQDVOVvZ60PDrh+rmX pSYDDxq4P83ZSSzNOoxXZRSusx52F2dNLu6WaNWYbNhId6ySZghEUH0DwmDZBoWgxJ X4iggWzxzFzLQ== Received-SPF: pass client-ip=64.215.233.21; envelope-from=sbaugh@janestreet.com; helo=mxout6.mail.janestreet.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296845 Archived-At: goto-address-mode binds C-c RET to goto-address-at-point when point is on a URL or email address. In special-mode buffers (or maybe any read-only buffer?) it should also bind RET while point is on the URL or email address. This would improve functionality for packages which create special-mode buffers showing arbitrary text that may contain URLs. For example, commit messages may contain URLs, and enabling goto-message-mode in vc-log buffers highlights those URLs, but RET doesn't work to follow them. Similarly, magit enables goto-address-mode in buffers showing a commit message, but it implements separate handling for RET on URLs since goto-address-mode doesn't provide that as a binding. This could be done with an extended-menu-item binding with a filter which checks (derived-mode-p 'special-mode), but maybe there's a better way?