From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections Date: Sat, 08 Jul 2023 13:07:37 -0400 Message-ID: References: <875y72ieq8.fsf@catern.com> <87cz193eno.fsf@yahoo.com> <87jzvgse4k.fsf@yahoo.com> <87pm58phyu.fsf@catern.com> <87y1jwqqel.fsf@yahoo.com> <87mt0bq4py.fsf@catern.com> <87mt06mk7w.fsf@catern.com> <831qhicpsy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36409"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, sbaugh@catern.com, 64423@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 08 19:08:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIBPu-0009Fl-SZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Jul 2023 19:08:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qIBPh-0007Ly-PI; Sat, 08 Jul 2023 13:08:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIBPf-0007Lb-Mb for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2023 13:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qIBPe-0001BU-4t for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2023 13:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qIBPe-0006X7-11 for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2023 13:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jul 2023 17:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64423 X-GNU-PR-Package: emacs Original-Received: via spool by 64423-submit@debbugs.gnu.org id=B64423.168883606525079 (code B ref 64423); Sat, 08 Jul 2023 17:08:01 +0000 Original-Received: (at 64423) by debbugs.gnu.org; 8 Jul 2023 17:07:45 +0000 Original-Received: from localhost ([127.0.0.1]:45128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIBPN-0006WP-ET for submit@debbugs.gnu.org; Sat, 08 Jul 2023 13:07:45 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:42757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIBPL-0006W6-9d for 64423@debbugs.gnu.org; Sat, 08 Jul 2023 13:07:44 -0400 In-Reply-To: <831qhicpsy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Jul 2023 19:48:29 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264782 Archived-At: Eli Zaretskii writes: >> Cc: Spencer Baugh , 64423@debbugs.gnu.org >> From: sbaugh@catern.com >> Date: Sat, 08 Jul 2023 16:39:00 +0000 (UTC) >> >> diff --git a/lisp/simple.el b/lisp/simple.el >> index 26944f1f72d..95d00cc506b 100644 >> --- a/lisp/simple.el >> +++ b/lisp/simple.el >> @@ -5618,8 +5618,10 @@ kill-new >> (if (fboundp 'menu-bar-update-yank-menu) >> (menu-bar-update-yank-menu string (and replace (car kill-ring))))) >> (when save-interprogram-paste-before-kill >> - (let ((interprogram-paste (and interprogram-paste-function >> - (funcall interprogram-paste-function)))) >> + (let ((interprogram-paste >> + (ignore-error 'quit >> + (and interprogram-paste-function >> + (funcall interprogram-paste-function))))) >> (when interprogram-paste >> (setq interprogram-paste >> (if (listp interprogram-paste) > > Are you sure this is TRT for all the implementations of GUI > selections? AFAIU, the discussion was only about X. Independent of that discussion, I think this change should be harmless. The worst thing that this change can cause is that a call to kill-new can complete successfully when it otherwise would have failed. That's probably always good, especially because kill-new is usually preceeded by deleting text, which might be unrecoverable in buffers without undo. But, also, I believe the discussion makes sense for platforms besides X: if there's a bug in the current owner of the clipboard, then taking ownership of the clipboard in Emacs will let us avoid that bug. And this change to ignore quits will allow the user to take ownership of the selection in that way, whereas they previously would not be able to (without manually writing some Lisp anyway).