Eli Zaretskii <eliz@gnu.org> writes:
>> From: Spencer Baugh <sbaugh@janestreet.com>
>> Date: Mon, 15 May 2023 14:11:08 -0400
>> 
>> The attached patch resolves this.  There's also a slight tweak to the
>> text of the menu entry for "Compile" to make it clearer that "compile"
>> runs in CWD, where as "project-compile" runs on the current project.
>> Otherwise I think it would be slightly confusing.
>
> Thanks.
>
>>  (defvar menu-bar-shell-commands-menu
>>    (let ((menu (make-sparse-keymap "Shell Commands")))
>> +    (bindings--define-key menu [project-interactive-shell]
>> +      '(menu-item "Run Shell Interactively In Project" project-shell
>> +                  :help "Run a subshell interactively, in the current project"))
>
> What does it mean to "run a shell in the current project"?  A shell
> doesn't run in a project.  Maybe you meant in the project's root
> directory?

Yes, changed to "In Project Root".

>> +    (bindings--define-key menu [project-compile]
>> +      '(menu-item "Compile Project..." project-compile
>> +                  :help "Invoke compiler or Make for current project, view compilation errors"))
>
> This tool-tip text is too long.  Maybe drop the "compilation" part.

Dropped.

>> +      '(menu-item "Compile Current Directory..." compile
>> +                  :help "Invoke compiler or Make in current directory, view compilation errors"))
>
> What is a "current directory" when you are talking about Emacs?

I usually think of the default-directory of the current buffer as the
"current directory".  But maybe that's not the terminology we want to
use?  How about "Compile Buffer" with help text "[...] in directory of
current buffer [...]"?

>> +	(list 'select-buffer-in-project
>> +	      'menu-item
>> +	      "Select Buffer In Project..."
>> +	      'project-switch-to-buffer
>> +	      :help "Prompt for a buffer name in the current project, and select that buffer in the current window")
>
> This tool-tip text is _way_ too long.

Shrunk.