From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#64088: [PATCH] Make project-root for vc projects return an absolute path Date: Mon, 10 Jul 2023 19:45:25 -0400 Message-ID: References: <3c6078aa-4089-46fd-18bb-d92be101ca4f@gutov.dev> <2690528f-bfc8-d164-c522-cd2fcf2ba1ba@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1355"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64088@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 11 01:46:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJ0aD-0000B3-Gk for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jul 2023 01:46:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJ0Zw-0003Ys-LA; Mon, 10 Jul 2023 19:46:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJ0Zu-0003Yd-JO for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 19:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJ0Zu-0007yy-BM for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 19:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJ0Zu-0007Fi-6s for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 19:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jul 2023 23:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64088 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64088-submit@debbugs.gnu.org id=B64088.168903273327824 (code B ref 64088); Mon, 10 Jul 2023 23:46:02 +0000 Original-Received: (at 64088) by debbugs.gnu.org; 10 Jul 2023 23:45:33 +0000 Original-Received: from localhost ([127.0.0.1]:49404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJ0ZQ-0007Ei-UL for submit@debbugs.gnu.org; Mon, 10 Jul 2023 19:45:33 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:58219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJ0ZP-0007ET-Cl for 64088@debbugs.gnu.org; Mon, 10 Jul 2023 19:45:31 -0400 In-Reply-To: <2690528f-bfc8-d164-c522-cd2fcf2ba1ba@gutov.dev> (Dmitry Gutov's message of "Mon, 10 Jul 2023 05:17:39 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264909 Archived-At: Dmitry Gutov writes: > On 27/06/2023 23:01, Spencer Baugh wrote: >> OK, how about this? > > Maybe we should go in the other direction? And call > abbreviate-file-name on them? > > Because otherwise in project-prompt-project-dir we'll always show the > expanded directory names, taking up extra space and usually repeating > the full name of the user's home directory for no good reason. That seems reasonable if we let-bind directory-abbrev-alist to nil around it; otherwise we'll be dependent on the user's configuration and we might add a directory in one way, and then they add a new value to directory-abbrev-alist and we add it again a second way. Although maybe that's fine? And probably users of directory-abbrev-alist would like to have those abbreviations show up in project-prompt-project-dir. Also we could always call abbreviate-file-name at project-prompt-project-dir time.