From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#62732: 29.0.60; uniquify-trailing-separator-p affects any buffer whose name matches a dir in CWD Date: Tue, 11 Jul 2023 08:31:51 -0400 Message-ID: References: <87h6tpn8d5.fsf@catern.com> <87edotn7sx.fsf@catern.com> <87edlhm6wq.fsf@catern.com> <87o7kklf9c.fsf@catern.com> <83r0pf9b7d.fsf@gnu.org> <83fs5v8tsw.fsf@gnu.org> <83edlf89qp.fsf@gnu.org> <83v8eq7j3i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7876"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: sbaugh@catern.com, Stefan Monnier , 62732@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 11 14:33:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJCYg-0001na-Lr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jul 2023 14:33:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJCYL-0000bT-Q9; Tue, 11 Jul 2023 08:33:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJCYB-0000WC-8H for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2023 08:33:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJCYA-0001Uk-Uu for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2023 08:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJCYA-0000mz-Aq for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2023 08:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jul 2023 12:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62732 X-GNU-PR-Package: emacs Original-Received: via spool by 62732-submit@debbugs.gnu.org id=B62732.16890787262965 (code B ref 62732); Tue, 11 Jul 2023 12:33:02 +0000 Original-Received: (at 62732) by debbugs.gnu.org; 11 Jul 2023 12:32:06 +0000 Original-Received: from localhost ([127.0.0.1]:49916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJCXC-0000lg-FF for submit@debbugs.gnu.org; Tue, 11 Jul 2023 08:32:05 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:35971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJCX7-0000l8-5P for 62732@debbugs.gnu.org; Tue, 11 Jul 2023 08:32:00 -0400 In-Reply-To: <83v8eq7j3i.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Jul 2023 15:01:21 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264927 Archived-At: Eli Zaretskii writes: >> From: Stefan Monnier >> Cc: sbaugh@catern.com, 62732@debbugs.gnu.org >> Date: Mon, 10 Jul 2023 22:55:23 -0400 >> >> >> No, `create-file-buffer` used to throw away the trailing slash, rather >> >> than make use of this information. >> >> [ And instead uniquify had to try and recover that information by checking >> the file-system. ] >> >> >> Not sure why Dired bothered to remove the tailing slash when calling >> >> it, maybe because a long time ago `create-file-buffer` had a bug if >> >> the name had a trailing slash. >> > So why the need for the change in dired.el? >> >> Because we do want Dired to tell `create-file-buffer` that this is >> a directory and it should thus obey `uniquify-trailing-separator-p`. > > When will we NOT want to tell create-file-buffer that the file is a > directory? Your original response, viz.: > >> I think the fact that the callers get to control this regardless of >> whether there is a file or directory by that name is one of the best >> part of this change. > > seemed to indicate that there are cases where we would not want > create-file-buffer to know that, but I suspect that we will always > want, because otherwise uniquify will not work in those cases, and > Spencer will report a bug. > > My comments assumed that indeed we will (almost) always want to tell > create-file-buffer this is a directory. One contribution, not intended to be exhaustive of all use cases, and not intended to be definitively a good idea: a user could want opened tar files with their file listing view to have a trailing slash, even though they aren't actually directories. And with my approach that is possibly just by running file-name-as-directory over the name before passing it to create-file-buffer.