From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#68799: 30.0.50; emacs --fg-daemon fails silently if server-start fails Date: Mon, 29 Jan 2024 12:32:00 -0500 Message-ID: References: <86y1c82hfb.fsf@gnu.org> <86wmrs2h41.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6495"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68799@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 29 18:33:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUVVV-0001Sx-Aw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jan 2024 18:33:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUVVH-0007AP-O2; Mon, 29 Jan 2024 12:33:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUVV8-00079q-UV for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 12:32:54 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUVV8-0005ZP-MP for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 12:32:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rUVVG-0005C8-U1 for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 12:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jan 2024 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68799 X-GNU-PR-Package: emacs Original-Received: via spool by 68799-submit@debbugs.gnu.org id=B68799.170654953619830 (code B ref 68799); Mon, 29 Jan 2024 17:33:02 +0000 Original-Received: (at 68799) by debbugs.gnu.org; 29 Jan 2024 17:32:16 +0000 Original-Received: from localhost ([127.0.0.1]:33356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUVUW-00059j-4Y for submit@debbugs.gnu.org; Mon, 29 Jan 2024 12:32:16 -0500 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:56789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUVUU-00059K-3r for 68799@debbugs.gnu.org; Mon, 29 Jan 2024 12:32:15 -0500 In-Reply-To: <86wmrs2h41.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 29 Jan 2024 19:18:22 +0200") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1706549520; bh=wnoC2Ra6lYYduzeuRHdG5ELReqtnd3kZvIUhFoBfxkE=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=YBmDm5EEtBK5kPfG+Bc6OyrLo5kSdX6Qvil00YnTUpOrO3ByYfbIR3KDK5pLbTs9n 7ycu/WS/2yH6UkfbS4vi8o2KS9ouiHjTUoIurg6Wa+rwmXkRDgafLjgJ5vTeBBJ84z ENAEXJzh34ozaDZM/siqJveuKNvf70Q8lL8nyQf9QgaQ7VqDsC09Nm7JKb+FgsMNYM 0DgLAKix09lVMrXJbz/LTTYecWhNgf9fUK+hb9ElmNfehWKhI94mpBVj6M9D8Znlqe ERvp3kkHhy9hsn4TATWEl1aeCrY7KdPN35LR1SnL5+13teEFwMOYKmNtNWNgdnsn0I fuA0WU3oPRrzA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279136 Archived-At: Eli Zaretskii writes: >> Cc: 68799@debbugs.gnu.org >> Date: Mon, 29 Jan 2024 19:11:36 +0200 >> From: Eli Zaretskii >> >> Have some faith in Emacs: we already do that. From startup.el: >> >> (let ((dn (daemonp))) >> (when dn >> (when (stringp dn) (setq server-name dn)) >> (server-start) >> (if server-process >> (daemon-initialized) >> (if (stringp dn) >> (message >> "Unable to start daemon: Emacs server named %S already running" >> server-name) >> (message "Unable to start the daemon.\nAnother instance of Emacs is running the server, either as daemon or interactively.\nYou can use emacsclient to connect to that Emacs process.")) >> (kill-emacs 1)))) >> >> So the problem seems to be that somehow server-start succeeds to leave >> a non-nil server-process variable behind, although testing that is the >> documented way of telling whether server is running. > > Or maybe server-start signals an error, and then the code which shows > an error message and shuts down Emacs doesn't get run? Yes, that's exactly what happens. So should we wrap a condition-case around server-start, I suppose?