From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#68689: 30.0.50; minibuffer-visible-completions should change completion-show-help Date: Wed, 24 Jan 2024 12:22:00 -0500 Message-ID: References: <86le8e3cgi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28946"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68689@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 24 18:23:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSgyG-0007Ii-EA for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jan 2024 18:23:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSgxq-00069H-4o; Wed, 24 Jan 2024 12:23:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSgxl-00067q-Sp for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 12:22:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSgxk-0006qD-SE for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 12:22:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rSgxq-00065B-6j for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 12:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68689 X-GNU-PR-Package: emacs Original-Received: via spool by 68689-submit@debbugs.gnu.org id=B68689.170611693323293 (code B ref 68689); Wed, 24 Jan 2024 17:23:02 +0000 Original-Received: (at 68689) by debbugs.gnu.org; 24 Jan 2024 17:22:13 +0000 Original-Received: from localhost ([127.0.0.1]:46511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSgx2-00063c-Tq for submit@debbugs.gnu.org; Wed, 24 Jan 2024 12:22:13 -0500 Original-Received: from mxout1.mail.janestreet.com ([38.105.200.78]:43563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSgx1-00063F-Bf for 68689@debbugs.gnu.org; Wed, 24 Jan 2024 12:22:11 -0500 In-Reply-To: <86le8e3cgi.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 24 Jan 2024 18:47:41 +0200") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1706116920; bh=FWRTqP3SDFdKAloRT55RGBlgFwaemD3cJYmL/DxxdlA=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=0YCRr+xqrJHqJsBRpnQLCmK38SXgy/Tc7I/aEsDIcfC55A33vEBbXzJXVwg6dP6q8 bIfU36mv3o31VbWOblmTD8rCdvctdfn9PIudNEJk9D4wUDvLEsAmW44IZD6RxTHYGU ZirUo21ZGZvAxn5C7FyMWwMVRYMFgLvP77s8HKXvvMho6egPlqjJQtM9TKWAmCYqZO F4Tp4yPeBhPUuSFdv6ihwIH26yat4Rfwn2mDS3UnQq5uKXgyTeVxOegWqqLObneaGm NX4z0rXOWOOs43MQFNM1agm8s4V4wYQy/UIWbexlrZrE9FWHA8n3qizweZaUJJw0DQ 6//aL8aobZt5Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278805 Archived-At: Juri Linkov writes: >> completion-show-help shows some useful help for new users. >> However, it suggests suboptimal bindings when >> minibuffer-visible-completions is on. minibuffer-visible-completions >> should change the help shown by completion-show-help. >> >> A patch to do this will follow. > > It's hard to see what your patch will output. > Could you please send the outputs of `emacs -Q` > to compare before and after your patch. With minibuffer-visible-completions=nil, there's no change. With minibuffer-visible-completions=t, before my patch: Click or type M-RET on a completion to select it. Type M- or M- to move point between completions. After my patch: Click or type RET on a completion to select it. Type , , , to move point between completions.