From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#71179: [PATCH] In rgrep, check matching files before excluding files Date: Sat, 25 May 2024 09:36:44 -0400 Message-ID: References: <86jzji1jpe.fsf@gnu.org> <864jamyrzy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37705"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , 71179@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 25 15:37:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAraR-0009cC-8y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 May 2024 15:37:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sArZx-0004xG-Ev; Sat, 25 May 2024 09:36:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sArZv-0004wl-DB for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 09:36:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sArZv-0004Q9-5D for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 09:36:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAra2-00078l-Ke for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 09:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 13:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71179-submit@debbugs.gnu.org id=B71179.171664421927433 (code B ref 71179); Sat, 25 May 2024 13:37:02 +0000 Original-Received: (at 71179) by debbugs.gnu.org; 25 May 2024 13:36:59 +0000 Original-Received: from localhost ([127.0.0.1]:43472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sArZz-00078O-5T for submit@debbugs.gnu.org; Sat, 25 May 2024 09:36:59 -0400 Original-Received: from mxout6.mail.janestreet.com ([64.215.233.21]:55203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sArZx-000782-5d for 71179@debbugs.gnu.org; Sat, 25 May 2024 09:36:57 -0400 In-Reply-To: <864jamyrzy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 May 2024 15:51:13 +0300") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1716644204; bh=xEkreuxb4SKPxgR2+8IiU8/q6nkhsIls7ZlrEQSvO+A=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=03nVTUjgirHX//kk5PpGvRJNtCf7G6LJk7//q8r9CKdv6UTrVyk/uBT8I9eDohtMB OupA4NYzqYEEzJg7LQCAdqJZA/qmtsbXZ3JUqfASoIcbbgTJi+U70/R8KOxjgATUlh g+kBfQLzQEYTG56YeuJq1Dq81bNE2LsTgl9Sy5R5BvSGz6d8Z43NUQ7F2b/ic+Zan0 jit2knG5vy2NBUc6kVhvEItNv24dSpz6OJPAAHVVzGwpoK+dCs9rYP+BwVh2ZBn4lU W2rpehZUUCr46ELchVz1RRITjH5oMufn2O75IiBZ2DgP/Qypsfr3thJrkbIvZhqeca zSm0OL8VpQYSA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285871 Archived-At: Eli Zaretskii writes: > The ones for whom the proposed change will affect the results. To be clear, the proposed change will not affect the content of the results returned by rgrep or any code in grep.el. For them, this change has no semantic effect at all, it only speeds things up. The only user-observable difference besides the speedup is that it fixes a bug: grep-find-ignored-files is documented to affect rgrep, and now that variable affects rgrep even if grep-find-template is set to a broken value (one which doesn't include ). It's unlikely anyone is relying on this buggy behavior when isn't present; the much more obvious way and documented way to achieve this behavior is to set grep-find-ignored-files to nil (which still works fine). I suppose we could preserve that bug by conditioning this optimization on (string-search "" grep-find-template), though.