bug#63539: 29.0.90; TRAMP fails to detect shell prompts containing ]

[Spencer Baugh <sbaugh@janestreet.com>]

Michael Albinus <michael.albinus@gmx.de> writes:

> Spencer Baugh <sbaugh@janestreet.com> writes:
>
> Hi Spencer,
>
>> Attempting to ssh to a machine with a prompt like:
>>
>> [user@hostname] foo/bar/path $
>>
>> will hang, because TRAMP thinks that the prompt ends at the "]", not the
>> "$".
>>
>> I guess this is because TRAMP supports prompts like "[foo bar baz]" with
>> no trailing $.  And it isn't greedy when reading the prompt, so it stops
>> at the first "]".
>>
>> One can work around this by configuring the machine's prompt, but []
>> seem relatively common in prompts (in my personal experience), and it
>> would be nice if this worked by default.  (So far I've only seen [] in
>> custom prompts but there are probably some OSs/distributions with [] in
>> their prompt by default)
>
> What's wrong with the recipe for your remote .profile:
>
> [[ $TERM == "dumb" ]] && PS1='$ ' && return
>
> The Tramp manual gives an extended version of the recipe, which handles
> also the zsh line editing problem, but you see the idea.

[] seem relatively common in prompts (in my personal experience), and it
would be nice if this worked by default.

Just as an additional point, I'm not always connecting to hosts that I
can trivially change the .profile for.

> And there is also the user option `tramp-shell-prompt-pattern' which you
> can customize as you like.

Yes, I'm setting this to remove the ] as a possible prompt character as
a workaround.

> Note, that Tramp cannot handle any case a user would prefer for
> detecting the prompt.

If it can cheaply handle more cases, why not?