From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries Date: Mon, 22 May 2023 15:49:59 -0400 Message-ID: References: <834jod1lvc.fsf@gnu.org> <83o7mkz2ap.fsf@gnu.org> <83sfbvxkj3.fsf@gnu.org> <3d97111e-794d-eeef-73b0-ee3f6f5f15d5@gutov.dev> <83jzx6w2bg.fsf@gnu.org> <6a3eed52-3248-74f9-bcaf-bf12660ae0ed@gutov.dev> <83h6savsz4.fsf@gnu.org> <83mt21vfgl.fsf@gnu.org> <86mt211vk3.fsf@mail.linkov.net> <0ce4532f-03aa-6afe-bd8f-8ef1df6615de@gutov.dev> <86ilco7qbs.fsf@mail.linkov.net> <83r0rctxbc.fsf@gnu.org> <867ct4b4ds.fsf@mail.linkov.net> <835y8otbub.fsf@gnu.org> <86o7mccl5z.fsf@mail.linkov.net> <83lehgp6s6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40674"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dmitry@gutov.dev, 63469@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 22 21:51:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1BYm-000APK-JD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 May 2023 21:51:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1BYd-0005lx-K8; Mon, 22 May 2023 15:51:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1BYc-0005ln-3z for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 15:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1BYb-0005dY-SU for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 15:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1BYb-0006pi-Ok for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 15:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 May 2023 19:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63469 X-GNU-PR-Package: emacs Original-Received: via spool by 63469-submit@debbugs.gnu.org id=B63469.168478500626139 (code B ref 63469); Mon, 22 May 2023 19:51:01 +0000 Original-Received: (at 63469) by debbugs.gnu.org; 22 May 2023 19:50:06 +0000 Original-Received: from localhost ([127.0.0.1]:36815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1BXi-0006nW-8E for submit@debbugs.gnu.org; Mon, 22 May 2023 15:50:06 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:59047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1BXg-0006mu-Hd for 63469@debbugs.gnu.org; Mon, 22 May 2023 15:50:05 -0400 In-Reply-To: <83lehgp6s6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 May 2023 21:20:25 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262188 Archived-At: Eli Zaretskii writes: >> From: Juri Linkov >> Cc: dmitry@gutov.dev, sbaugh@janestreet.com, 63469@debbugs.gnu.org >> Date: Mon, 22 May 2023 20:48:08 +0300 >> >> >> It can be used for anything. For example, to display the project name >> >> on the mode-line. (Then better to cache the project name in a new >> >> buffer-local variable.) >> > >> > I don't see anything but the menu in the patch you suggested. I >> > understand that in principle we could do many things there, but if you >> > are proposing a real patch, not just an initial idea, please show all >> > of the code you want to include in this mode. >> >> Actually I miss this feature very much. There is already the mode-line >> indication with the VC system name and the VC branch name, but >> no indication with a project name, so similar files >> in different projects all are showing the same "Git-master". > > We can show this on the mode line always, whenever there's a project. > No need for a minor mode. This might get crowded when there's also the VC modeline indicator. Still, I would like this feature. And actually, the mention of VC makes me realize: We already do something expensive by default for every new buffer: Query the VC state. So maybe it's not so bad to run project-current every time we make a new buffer? Or at least, in the exact same situations that we query the VC state? Maybe we can even implement some sharing between the project-current lookup and the VC state query, for the vc project backend? >> Now here is the implementation of 'project-mode' based on 'vc-mode', >> and 'project-menu-entry' based on 'vc-menu-entry' that shows >> a project name alongside of vc info, and the mouse click opens >> the project menu using 'menu-bar-project-menu' implemented by Spencer. > > I still don't understand why this has to be a minor mode. Both > mode-line indication and the menu bar can show this stuff regardless > of any mode. It sounds like this mode is an unnecessary complication. (I personally agree that this should be always on, with perhaps a user option to turn it off.)