From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#69809: 30.0.50; flymake: error in process sentinel Date: Wed, 24 Jul 2024 12:25:00 -0400 Message-ID: References: <867chv3mtf.fsf@gnu.org> <87le696o86.fsf@catern.com> <86v81bktv5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31674"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gerd.moellmann@gmail.com, sbaugh@catern.com, Eli Zaretskii , Eshel Yaron , 69809@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 24 18:26:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWeof-0007tJ-5Y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jul 2024 18:26:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWeoP-0000vF-JS; Wed, 24 Jul 2024 12:25:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWeoO-0000v5-8Y for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 12:25:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWeoN-0002Ja-Vs for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 12:25:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sWeoT-0004Jp-VA for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 12:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2024 16:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69809 X-GNU-PR-Package: emacs Original-Received: via spool by 69809-submit@debbugs.gnu.org id=B69809.172183831416543 (code B ref 69809); Wed, 24 Jul 2024 16:26:01 +0000 Original-Received: (at 69809) by debbugs.gnu.org; 24 Jul 2024 16:25:14 +0000 Original-Received: from localhost ([127.0.0.1]:34360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWeni-0004Ik-9Q for submit@debbugs.gnu.org; Wed, 24 Jul 2024 12:25:14 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:52133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWeng-0004IT-ET for 69809@debbugs.gnu.org; Wed, 24 Jul 2024 12:25:13 -0400 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 18 Jul 2024 00:54:20 +0100") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1721838300; bh=EObQugENTBAco5tFvXrZn903tOGvcLpddSc7spJxXN0=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=XKzwzo9AZ9LjFWRdfe7Wf4LAf0f3FXSDEkAKluxt8XP9c5hojiDEp3vLageW/xeN8 /mhdTaDPomR+CVuJpLUOZkkjWvV2f7WchUNflKJBUNP/gCqASAVm12NnInFVntCaFK t5Uy5AfR5YBKr+VVtbgCvR+yLkIhIrRct7m3T8iqU7KAvwNF026zQGBFfCCFOCfDqH l7jyVW3+em18JL34x+GOkMg7Q6A1oWosc+hpfYtLTRyyGFs7uJ//DNM+WhvmeM3/to 5rRqcLtFukopqlhnFGZFyOWLFdl5vOlgA5iyDj7XwbCVCVsFcBggsXUghru2SWJo3e JNWaL7GotwufQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289236 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > On Wed, Jul 17, 2024 at 6:38=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > >> > > Anyway, can you try this patch? >> > >> > That seems to work too :) >> >> I understand the source of _this_ problem, and the line I changed >> addresses it. My worry is that my fix also creates more problems, >> but it seems cleaner. > > Indeed it did create some subtle problems with "foreign diagnostics". > I made a better patch, attached. It should fix the Eglot/flymake-cc > scenario and be a net improvement for Flymake. Also adds a new > Flymake test. > > Spencer please have a look and push it if you agree. Yes, this seems good to me, thank you for the improved patch! I unfortunately don't have commit access, so perhaps someone else can install the patch.