From: Spencer Baugh <sbaugh@janestreet.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: gerd.moellmann@gmail.com, sbaugh@catern.com,
Eli Zaretskii <eliz@gnu.org>, Eshel Yaron <me@eshelyaron.com>,
69809@debbugs.gnu.org
Subject: bug#69809: 30.0.50; flymake: error in process sentinel
Date: Wed, 24 Jul 2024 12:25:00 -0400 [thread overview]
Message-ID: <ierikwudag3.fsf@janestreet.com> (raw)
In-Reply-To: <CALDnm53ApRju5VCTwZEj-eJn0kEXt0FdpF8a=SX-LYKwYAMBgQ@mail.gmail.com> ("João Távora"'s message of "Thu, 18 Jul 2024 00:54:20 +0100")
João Távora <joaotavora@gmail.com> writes:
> On Wed, Jul 17, 2024 at 6:38 PM João Távora <joaotavora@gmail.com> wrote:
>
>> > > Anyway, can you try this patch?
>> >
>> > That seems to work too :)
>>
>> I understand the source of _this_ problem, and the line I changed
>> addresses it. My worry is that my fix also creates more problems,
>> but it seems cleaner.
>
> Indeed it did create some subtle problems with "foreign diagnostics".
> I made a better patch, attached. It should fix the Eglot/flymake-cc
> scenario and be a net improvement for Flymake. Also adds a new
> Flymake test.
>
> Spencer please have a look and push it if you agree.
Yes, this seems good to me, thank you for the improved patch!
I unfortunately don't have commit access, so perhaps someone else can
install the patch.
next prev parent reply other threads:[~2024-07-24 16:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 7:09 bug#69809: 30.0.50; flymake: error in process sentinel Gerd Möllmann
2024-03-21 10:23 ` Eli Zaretskii
2024-03-23 14:02 ` sbaugh
2024-03-23 14:20 ` Gerd Möllmann
2024-07-11 9:45 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-11 11:15 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-11 11:46 ` Gerd Möllmann
2024-07-12 6:27 ` Eli Zaretskii
2024-07-16 20:48 ` Spencer Baugh
2024-07-17 6:12 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-17 8:20 ` João Távora
2024-07-17 9:07 ` João Távora
2024-07-17 13:08 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-17 13:44 ` João Távora
2024-07-17 17:25 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-17 17:38 ` João Távora
2024-07-17 23:54 ` João Távora
2024-07-18 0:10 ` João Távora
2024-07-24 16:25 ` Spencer Baugh [this message]
2024-07-25 7:28 ` Eli Zaretskii
2024-07-25 7:45 ` João Távora
2024-07-25 10:50 ` Eli Zaretskii
2024-07-25 11:49 ` João Távora
2024-07-27 7:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ierikwudag3.fsf@janestreet.com \
--to=sbaugh@janestreet.com \
--cc=69809@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=joaotavora@gmail.com \
--cc=me@eshelyaron.com \
--cc=sbaugh@catern.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).