From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#69189: 30.0.50; minibuffer-visible-completions doesn't work in completing-read-multiple Date: Wed, 07 Aug 2024 11:19:40 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Juri Linkov To: 69189@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 07 17:20:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbiTB-0000fy-LZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Aug 2024 17:20:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbiSs-0006sH-1W; Wed, 07 Aug 2024 11:20:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbiSr-0006s0-3S for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2024 11:20:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbiSq-0003Cw-Qv for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2024 11:20:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=1RCq19aw2IwCcNe2aP6OMJ1frok0DgNNMRl5y/4mWJw=; b=F64wgkm+B9+Uf/Lg0NeNFTvZovB2295II9vIiIyeyB4+KkSK42WCgtYpQbBcZSeUP4JFO6jpt4QE6nFWoidVpry7hXCV0Ofz40CO6y6PbU5Mh1CDSVRuZ/jyn6nvOO27BrMK/MaZAcPEF1+DXQudtxddt1bx58IPFWXDVcp53MVNVZ82Jjz8Sa8qvN6rA3RdyTPIQnryWJ1Z4mrYvCuaN7D+GBl+Y3h2l079+4v8hRydSDlJSKjYjhPkqGD6ohzKa7wWaYqlP/AAx4Teipj+Kyth/dtvGb4L1CXV+H8LfkREytGCthw1ff8HPWKYvb54xcuc1xh/hR/tYWq6oO9/kw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbiTF-0001rJ-RF for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2024 11:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Aug 2024 15:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69189 X-GNU-PR-Package: emacs Original-Received: via spool by 69189-submit@debbugs.gnu.org id=B69189.17230440137059 (code B ref 69189); Wed, 07 Aug 2024 15:21:01 +0000 Original-Received: (at 69189) by debbugs.gnu.org; 7 Aug 2024 15:20:13 +0000 Original-Received: from localhost ([127.0.0.1]:34920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbiST-0001pn-6u for submit@debbugs.gnu.org; Wed, 07 Aug 2024 11:20:13 -0400 Original-Received: from mxout6.mail.janestreet.com ([64.215.233.21]:52941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbiSR-0001pV-4M for 69189@debbugs.gnu.org; Wed, 07 Aug 2024 11:20:11 -0400 In-Reply-To: (Spencer Baugh's message of "Thu, 15 Feb 2024 17:12:33 -0500") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1723043980; bh=1RCq19aw2IwCcNe2aP6OMJ1frok0DgNNMRl5y/4mWJw=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=09UoKLyyIhZbhwUxQPzfHLr948jwJzJMR6dnPxmCR2lydwZBgsgYklvykVP159WP/ b7aIxvM2JY0JoxMzmTwxGUYpLVCP7pmuEeZ6j3ZAwruxSJLvEB3qVO+rMCFavvTG/d EGHmXirnrhRmOCsuhBpVl62T1B9buxY0E5Ta8NX3l7uE4/BGmoina3j1HRhX1FrXVG JV+Z6t8mXxjKTbLFWmL1JiZTAtvAQ3KMFJI4fqHZ7cE5Ebg0FnEWfRKbv41QwgJaWS ylC3q1Wqjp1698Ms6RfI5ZXsMYtP9Njku0v4n9MQpd/Siz7/NajfqQ7z5TVHv2R5tc ZRfUgMwRoM8Cg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289894 Archived-At: --=-=-= Content-Type: text/plain Here's a patch to fix this. Eli, is this OK for emacs-30? Since this is fixing a bug in a customization which is new in Emacs 30. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Support-minibuffer-visible-completions-in-completing.patch >From 6688344ce5ffb0738751d83a4a8acc4068b453e5 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Wed, 7 Aug 2024 11:18:02 -0400 Subject: [PATCH] Support minibuffer-visible-completions in completing-read-multiple All that's required is to add minibuffer-visible-completions-map on top of the completing-read-multiple map; this is the same thing that minibuffer-visible-completions does in completing-read-default. * lisp/emacs-lisp/crm.el (completing-read-multiple): Add minibuffer-visible-completions-map (bug#69189) --- lisp/emacs-lisp/crm.el | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el index 253dfc6237a..422a8d52dcf 100644 --- a/lisp/emacs-lisp/crm.el +++ b/lisp/emacs-lisp/crm.el @@ -238,6 +238,11 @@ completing-read-multiple (let* ((map (if require-match crm-local-must-match-map crm-local-completion-map)) + (map (if minibuffer-visible-completions + (make-composed-keymap + (list minibuffer-visible-completions-map + map)) + map)) input) (minibuffer-with-setup-hook (lambda () -- 2.39.3 --=-=-=--