From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries Date: Mon, 22 May 2023 17:20:19 -0400 Message-ID: References: <83o7mkz2ap.fsf@gnu.org> <83sfbvxkj3.fsf@gnu.org> <3d97111e-794d-eeef-73b0-ee3f6f5f15d5@gutov.dev> <83jzx6w2bg.fsf@gnu.org> <6a3eed52-3248-74f9-bcaf-bf12660ae0ed@gutov.dev> <83h6savsz4.fsf@gnu.org> <83mt21vfgl.fsf@gnu.org> <86mt211vk3.fsf@mail.linkov.net> <0ce4532f-03aa-6afe-bd8f-8ef1df6615de@gutov.dev> <86ilco7qbs.fsf@mail.linkov.net> <83r0rctxbc.fsf@gnu.org> <867ct4b4ds.fsf@mail.linkov.net> <835y8otbub.fsf@gnu.org> <86o7mccl5z.fsf@mail.linkov.net> <83lehgp6s6.fsf@gnu.org> <9b95edb4-ce9e-9dfe-4ad8-24d08422a5ae@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14923"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Juri Linkov , 63469@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 22 23:21:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1Cxz-0003ii-41 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 May 2023 23:21:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1Cxk-0003W1-3O; Mon, 22 May 2023 17:21:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1Cxi-0003Vm-It for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 17:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1Cxi-0006Wp-AM for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 17:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1Cxi-00015N-5s for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 17:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 May 2023 21:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63469 X-GNU-PR-Package: emacs Original-Received: via spool by 63469-submit@debbugs.gnu.org id=B63469.16847904274085 (code B ref 63469); Mon, 22 May 2023 21:21:02 +0000 Original-Received: (at 63469) by debbugs.gnu.org; 22 May 2023 21:20:27 +0000 Original-Received: from localhost ([127.0.0.1]:36935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1Cx8-00013o-GG for submit@debbugs.gnu.org; Mon, 22 May 2023 17:20:26 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:44037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1Cx6-00013Y-Nv for 63469@debbugs.gnu.org; Mon, 22 May 2023 17:20:25 -0400 In-Reply-To: <9b95edb4-ce9e-9dfe-4ad8-24d08422a5ae@gutov.dev> (Dmitry Gutov's message of "Mon, 22 May 2023 22:54:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262192 Archived-At: Dmitry Gutov writes: > On 22/05/2023 22:49, Spencer Baugh wrote: >> And actually, the mention of VC makes >> me realize: We already do something expensive by default for every new >> buffer: Query the VC state. So maybe it's not so bad to run >> project-current every time we make a new buffer? Or at least, in the >> exact same situations that we query the VC state? Maybe we can even >> implement some sharing between the project-current lookup and the VC >> state query, for the vc project backend? > > The VC project backend is not the only backend out there. Others' > performance characteristics may well be different. > > Further, its root-finding logic is different from VC. We also cannot > simply see which backend the current file is registered at because > project-vc has different options which affect how the root is > determined. > > Long story short, we won't be able to simply reuse VC's cached info. I assume you've already considered this thoroughly, but could we just get rid of all those differences/merge them into vc? For example, I wonder if we could teach vc to have an option like project-vc-merge-submodules... or at least, teach vc to discover the parent project. That could maybe be useful in vc... >> (I personally agree that this should be always on, with perhaps a user > option to turn it off.) > > I'm fairly sure not everybody will like the additional delay when > visiting files over Tramp. We could simply not run it automatically for files on TRAMP. Do we run the vc find-file hook for files on TRAMP? Maybe we shouldn't...