From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Thu, 20 Jul 2023 13:08:24 -0400 Message-ID: References: <1fd5e3ed-e1c3-5d6e-897f-1d5d55e379fa@gutov.dev> <87wmyupvlw.fsf@localhost> <5c4d9bea-3eb9-b262-138a-4ea0cb203436@gutov.dev> <87tttypp2e.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30564"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , 64735@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 20 19:09:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMX9X-0007iD-HF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jul 2023 19:09:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMX9E-0003on-Vi; Thu, 20 Jul 2023 13:09:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMX9B-0003of-Un for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 13:09:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMX9B-0000ZI-Mx for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 13:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMX9B-0008HO-Ir for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 13:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jul 2023 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.168987291531791 (code B ref 64735); Thu, 20 Jul 2023 17:09:01 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 20 Jul 2023 17:08:35 +0000 Original-Received: from localhost ([127.0.0.1]:59756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMX8l-0008Gh-AE for submit@debbugs.gnu.org; Thu, 20 Jul 2023 13:08:35 -0400 Original-Received: from mxout5.mail.janestreet.com ([64.215.233.18]:32891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMX8g-0008GR-RD for 64735@debbugs.gnu.org; Thu, 20 Jul 2023 13:08:33 -0400 In-Reply-To: <87tttypp2e.fsf@localhost> (Ihor Radchenko's message of "Thu, 20 Jul 2023 15:42:17 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265622 Archived-At: Ihor Radchenko writes: > Dmitry Gutov writes: > >>>> ... Last I checked, Lisp-native file >>>> listing was simply slower than 'find'. >>> >>> Could it be changed? >>> In my tests, I was able to improve performance of the built-in >>> `directory-files-recursively' simply by disabling >>> `file-name-handler-alist' around its call. >> >> Then it won't work with Tramp, right? I think it's pretty nifty that >> project-find-regexp and dired-do-find-regexp work over Tramp. > > Sure. It might also be optimized. Without trying to convince find devs > to do something about regexp handling. Not to derail too much, but find as a subprocess has one substantial advantage over find in Lisp: It can run in parallel with Emacs, so that we actually use multiple CPU cores. Between that, and the remote support part, I personally much prefer find to be a subprocess rather than in Lisp. I don't think optimizing directory-files-recursively is a great solution. (Really it's entirely plausible that Emacs could be improved by *removing* directory-files-recursively, in favor of invoking find as a subprocess: faster, parallelized execution, and better remote support.)